-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mocks for ApplicationSet Gitea, GitHub, and GitLab unit tests #9287
Labels
component:application-sets
Bulk application management related
component:test
Test requests (e2e or unit)
enhancement
New feature or request
Comments
crenshaw-dev
added
enhancement
New feature or request
component:application-sets
Bulk application management related
component:test
Test requests (e2e or unit)
labels
May 3, 2022
@crenshaw-dev Can you assign the issue to me? thx! |
Lets include github and gitlab mock too with this issue |
10 tasks
@crenshaw-dev : can u please assign to me as well, as github supports multiple asignee and edit title as well |
crenshaw-dev
changed the title
Use mocks for ApplicationSet Gitea unit tests
Use mocks for ApplicationSet Gitea, GitHub, and GitLab unit tests
May 5, 2022
@ashutosh16 : any update for gitea change? |
Reopened for gitea. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:application-sets
Bulk application management related
component:test
Test requests (e2e or unit)
enhancement
New feature or request
Summary
The Gitea unit tests for the PR and SCM generators currently make external API calls. This makes the tests flaky. We should instead use a mocked service.
https://github.com/argoproj/argo-cd/blob/master/applicationset/services/scm_provider/gitea_test.go
https://github.com/argoproj/argo-cd/blob/master/applicationset/services/pull_request/gitea_test.go
Motivation
Last week integration tests were broken for a couple days because of a change in the tested Gitea org.
Proposal
We could follow the model of the Bitbucket tests and use a mocked service.
argo-cd/applicationset/services/pull_request/bitbucket_server_test.go
Line 14 in 1d765a0
The text was updated successfully, but these errors were encountered: