Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s client version is blank after removing client binary #5325

Closed
3 tasks done
jsoref opened this issue Jan 27, 2021 · 1 comment · Fixed by #5386
Closed
3 tasks done

k8s client version is blank after removing client binary #5325

jsoref opened this issue Jan 27, 2021 · 1 comment · Fixed by #5386
Assignees
Labels
bug/priority:medium Should be fixed in the next minor releases bug/severity:minor Bug has limited impact, maybe affects only an edge-case or is of cosmetic nature bug Something isn't working
Milestone

Comments

@jsoref
Copy link
Member

jsoref commented Jan 27, 2021

If you are trying to resolve an environment-specific issue or have a one-off question about the edge case that does not require a feature then please consider asking a question in argocd slack channel.

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

#5101 removed kubectl from the image leaving a blank version box.

To Reproduce

  1. Load https://cd.apps.argoproj.io/applications/argo-cd
  2. Click the version (v1.9.0+7165b45)

Expected behavior

Report k8s client version

Screenshots

image

Version

{
    "Version": "v1.9.0+7165b45",
    "BuildDate": "2021-01-26T21:23:37Z",
    "GitCommit": "7165b45aeaa15044cec514e7de3d300d448b2df9",
    "GitTreeState": "clean",
    "GoVersion": "go1.14.12",
    "Compiler": "gc",
    "Platform": "linux/amd64",
    "KsonnetVersion": "v0.13.1",
    "KustomizeVersion": "v3.8.1 2020-07-16T00:58:46Z",
    "HelmVersion": "v3.4.1+gc4e7485",
    "JsonnetVersion": "v0.17.0"
}

Logs

Paste any relevant application logs here.
@jsoref jsoref added the bug Something isn't working label Jan 27, 2021
@jannfis
Copy link
Member

jannfis commented Jan 27, 2021

Yes, it is definitely a bug that we don't show the Kubernetes client version used. But the goal of the mentioned PR was not to remove version information, but to remove the kubectl binary since we've moved to using the client libraries from Kubernetes instead of the binary.

So, the correct fix to this issue would be to properly display the Kubernetes client version instead of removing the row/information altogether, I think.

@iam-veeramalla do you want to take a look, please?

@jannfis jannfis added bug/priority:medium Should be fixed in the next minor releases bug/severity:minor Bug has limited impact, maybe affects only an edge-case or is of cosmetic nature labels Jan 27, 2021
@jannfis jannfis added this to the v1.9 milestone Jan 27, 2021
@jsoref jsoref changed the title kubectl still visible in version kubectl version is blank after removing client binary Jan 27, 2021
@jsoref jsoref changed the title kubectl version is blank after removing client binary k8s client version is blank after removing client binary Jan 27, 2021
rbreeze added a commit to rbreeze/argo-cd that referenced this issue Jan 27, 2021
@alexmt alexmt self-assigned this Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/priority:medium Should be fixed in the next minor releases bug/severity:minor Bug has limited impact, maybe affects only an edge-case or is of cosmetic nature bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants