Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The app diff UI button includes temporary resources from hooks #3143

Closed
dthomson25 opened this issue Feb 21, 2020 · 2 comments · Fixed by #14816
Closed

The app diff UI button includes temporary resources from hooks #3143

dthomson25 opened this issue Feb 21, 2020 · 2 comments · Fixed by #14816
Labels
bug/priority:medium Should be fixed in the next minor releases bug/severity:major Malfunction in one of the core component, impacting a majority of users bug Something isn't working component:ui User interfaces bugs and enhancements

Comments

@dthomson25
Copy link
Member

Describe the bug
If a user clicks the app diff button with an application with hooks, those hooks show up as resources that need to be removed. This behavior is misleading as users think their app is out of sync, but it's actually healthy.

To Reproduce

  1. Create an app with a hook
  2. Sync it
  3. Click the app diff button

Expected behavior
If an application with hook is synced, no resources should appear on the app diff page.
@dthomson25 dthomson25 added bug Something isn't working ui labels Feb 21, 2020
@alexmt alexmt added bug/priority:medium Should be fixed in the next minor releases bug/severity:major Malfunction in one of the core component, impacting a majority of users labels Apr 9, 2020
@jannfis jannfis added the component:ui User interfaces bugs and enhancements label May 14, 2020
@jessesuen jessesuen removed the ui label Aug 27, 2020
@ciiay
Copy link
Contributor

ciiay commented Aug 9, 2021

@dthomson25 Hi, I tried to reproduce this issue, after application is synced up, the Diff button is disabled. Could you confirm if it's ok to close this issue? Thanks!

@vroldanbet
Copy link

vroldanbet commented Jan 31, 2023 •
edited
Loading

We see the same phenomenon when resources have Helm hooks. The App Diff button shows the resource as being removed (marked in red) when in fact is not going to be changed at all. This will only show up if there is any other resource that has an actual diff. Once the sync is completed, the App Diff button is greyed out.

Argo version v2.4.8+844f79e

@alexmt alexmt mentioned this issue Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/priority:medium Should be fixed in the next minor releases bug/severity:major Malfunction in one of the core component, impacting a majority of users bug Something isn't working component:ui User interfaces bugs and enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ManagedResources API should not return diff for hooks alexmt/argo-cd
6 participants
@alexmt @jannfis @vroldanbet @dthomson25 @jessesuen @ciiay