Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI banner empty when permanent and no explicate bannerposition #16740

Closed
3 tasks done
igaskin opened this issue Jan 4, 2024 · 1 comment · Fixed by #16741
Closed
3 tasks done

UI banner empty when permanent and no explicate bannerposition #16740

igaskin opened this issue Jan 4, 2024 · 1 comment · Fixed by #16741
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements

Comments

@igaskin
Copy link
Member

igaskin commented Jan 4, 2024

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug
The optional UI banner does not appear if there is no explicate value set for ui.bannerposition.

Possibly related to this PR: #14623

To Reproduce
Set the following in the argocd-cm

does work

data:
  ui.bannercontent: reproduce banner bug
  ui.bannerpermanent: "true"
  ui.bannerposition: top  
Screenshot 2024-01-03 at 4 04 31 PM

does not work

data:
  ui.bannercontent: reproduce banner bug
  ui.bannerpermanent: "true"
Screenshot 2024-01-03 at 4 03 46 PM

Expected behavior

Screenshots

Version

argocd version
argocd: v2.6.3+e05298b.dirty
  BuildDate: 2023-02-27T15:43:43Z
  GitCommit: e05298b9c6ab8610104271fa8491f019fee3c587
  GitTreeState: dirty
  GoVersion: go1.20.1
  Compiler: gc
  Platform: darwin/arm64
argocd-server: v2.10.0-rc1+d919606
  BuildDate: 2023-12-18T20:45:12Z
  GitCommit: d9196060c2d8ea3eadafe278900e776760c5fcc6
  GitTreeState: clean
  GoVersion: go1.21.3
  Compiler: gc
  Platform: linux/arm64
  Kustomize Version: v5.2.1 2023-10-19T20:13:51Z
  Helm Version: v3.13.2+g2a2fb3b
  Kubectl Version: v0.26.11
  Jsonnet Version: v0.20.0

Logs

Paste any relevant application logs here.
@igaskin igaskin added the bug Something isn't working label Jan 4, 2024
@keithchong keithchong added the component:ui User interfaces bugs and enhancements label Jan 23, 2024
@keithchong
Copy link
Contributor

This appears to be a regression. In the sample config here, the default behavior was such that if the bannerposition was not specified, the content would appear in the the banner at the top of the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants