Rename source ref
to name
and make it a merge key
#15975
Labels
enhancement
New feature or request
Milestone
Summary
Motivation
Patching lists is difficult. It's easier with strategic merge patching when you define a merge key for the list items.
Adding this merge key would let users patch Applications using Kustomize or kubectl in a more precise and intuitive way.
It would also allow
ignoreApplicationDifferences
in ApplicationSets to avoid strange behavior when trying to ignore individual fields in list items.Proposal
ref
toname
. Why reuseref
? It already serves the similar purpose of uniquely identifying a source. Why call itname
? Because that's more standard/expected for merge keys on lists.We shouldn't do this until Argo 3.0, because 1) renaming a field is a breaking API change, and 2) requiring the previously-optional field is another breaking API change.
Argo 3.0 should provide a mechanism to automatically rename the field on conversion, but it'll still have to throw an error and ask the user to name unnamed sources.
The text was updated successfully, but these errors were encountered: