Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppSet degraded on v2.9.0-rc2- "" is invalid: patch: Invalid value #15900

Closed
3 tasks done
shuker85 opened this issue Oct 11, 2023 · 3 comments · Fixed by #16056
Closed
3 tasks done

AppSet degraded on v2.9.0-rc2- "" is invalid: patch: Invalid value #15900

shuker85 opened this issue Oct 11, 2023 · 3 comments · Fixed by #16056
Assignees
@alexmt
Labels
bug Something isn't working component:application-sets Bulk application management related regression Bug is a regression, should be handled with high priority
Milestone
v2.9

Comments

@shuker85
Copy link
Contributor

shuker85 commented Oct 11, 2023 •
edited
Loading

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

I'd deployed an upgrade from v2.8.3 to v2.9.0-rc2 (custom build image), and the appsets turned into degraded state.

To Reproduce

ApplicationSet: https://gist.github.com/shuker85/787faba4ad3818370a49b5f0b0603095 (it did not fit also in the max comment size here) , but we've serverSideApply: true

This was working fine on v2.8.3
Expected behavior

Version

Paste the output from `argocd version` here.

Logs

Paste any relevant application logs here.
@shuker85 shuker85 added the bug Something isn't working label Oct 11, 2023
@crenshaw-dev
Copy link
Member

@alexmt I suspect that this is associated with the change from Update to Patch: #15514

@crenshaw-dev crenshaw-dev added regression Bug is a regression, should be handled with high priority component:application-sets Bulk application management related labels Oct 11, 2023
@crenshaw-dev crenshaw-dev added this to the v2.9 milestone Oct 11, 2023
@shuker85
Copy link
Contributor Author

git revert 21672a2a8373adca5cc0203b09d5f65521928d58 and build from that fixes the issue for me

@alexmt alexmt self-assigned this Oct 11, 2023
@alexmt
Copy link
Collaborator

alexmt commented Oct 11, 2023

working on it!

@alexmt alexmt mentioned this issue Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexmt alexmt

Labels
bug Something isn't working component:application-sets Bulk application management related regression Bug is a regression, should be handled with high priority
Projects
None yet
Milestone
v2.9
Development

Successfully merging a pull request may close this issue.

fix(appset): ensure appset don't attempt to remove application kind in patch requests alexmt/argo-cd
3 participants
@crenshaw-dev @alexmt @shuker85