UI: Only automatically group pods once

[maartengo]

Checklist:

• I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• I've included steps to reproduce the bug.
• I've pasted the output of argocd version.

Describe the bug

In an application with more than 15 pods, each change in pod count triggers the following

Since the number of pods has surpassed the threshold pod count of 15, you will now be switched to the group node view. If you prefer the tree view, you can simply click on the Group Nodes toolbar button to deselect the current view.

However, this keeps happening after the first automated grouping.

To Reproduce

1. Deploy 15 pods in a single application. Add sync hooks that deploy additional pods on sync, or use syncwaves to trigger more deployments. We deploy prometheus and thanos in a single application, which has the same effect.
2. Deploy a new version of the pods, or just start a sync without changes
3. You should get multiple 'Since the number of pods...' messages, regardless of the current grouping option

Expected behavior

The message should only occur once.

Another related issue (should I create a new issue for this?) is that it always groups the pods whenever the amount of pods change (so long as you have > 15 pods). Manually deselecting the grouping is overwritten.

Screenshots

Version

{
    "Version": "v2.8.0+804d4b8",
    "BuildDate": "2023-08-07T14:25:33Z",
    "GitCommit": "804d4b8ca6bc4c2cf02c5c971aa923ec5b8623f0",
    "GitTreeState": "clean",
    "GoVersion": "go1.20.6",
    "Compiler": "gc",
    "Platform": "linux/amd64",
    "KustomizeVersion": "v5.1.0 2023-06-19T16:58:18Z",
    "HelmVersion": "v3.12.1+gf32a527",
    "KubectlVersion": "v0.24.2",
    "JsonnetVersion": "v0.20.0"
}

Logs

Paste any relevant application logs here.

[maartengo]

Just found another issue related to this feature: Switching views also triggers the message. E.g. switching from 'list' to 'tree' view also triggers the grouping, but in reverse?

No matter your original grouping, it will ungroup your pods while still printing the 'Since the number of pods...' message.

[crenshaw-dev]

WIP to solve this: #14821

[maartengo]

WIP to solve this: #14821

This seems to solve the issue of the repeating notifications. Does this also solve the problem that it keeps trying to group pods, regardless of what the user wants? e.g. if I manually deselect the 'group pods' feature, will it still group pods on the next pod count change?

[crenshaw-dev]

Ah, good question. I think the answer is "no."

[jtcressy]

Is there any good workaround to disable this "feature"? such as editing a configmap or something to specify some setting? We recently upgraded to 2.8 and this UI change is driving us crazy.

[crenshaw-dev]

We got an internal request to improve the experience as well. @ashutosh16 would you like to describe here what we proposed for the internal user?

[ashutosh16]

@jtcressy/@maartengo Based on the feedback, i've made some changes where the message and group nodes will be displayed once per app and will not be displayed again to the user. Pls see the attach video. It would be great if you can review the changes?

Screen.Recording.2023-08-22.at.7.11.38.PM.mov

[maartengo]

@ashutosh16 this looks great! The only thing that I noticed is that test2 became grouped after you grouped test3. I think that can be a bit confusing, but otherwise its a great improvement.

[ashutosh16]

@maartengo

@ashutosh16 this looks great! The only thing that I noticed is that test2 became grouped after you grouped test3. I think that can be a bit confusing, but otherwise its a great improvement.

That is the default behavior of ArgoCD, If the user selects a grouping node, the user interface will remain in the grouping until you unselect. The groupNode feature is a global preference and is applicable to all apps

[jtcressy]

@ashutosh16 LGTM! I especially love that you changed it to a tooltip for the groupNodes button, directing the user to the control visually.

[crenshaw-dev]

This change is released with 2.8.2. Thanks everyone!