This repository has been archived by the owner on Jul 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgwest
suggested changes
Sep 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @shmurata! A couple of tweaks requested... and it looks like you need to add the new generator doc file to mkdocs.yml
as well.
@jgwest Thanks for the review. |
Added to mkdocs.yml in 6e81ce5. |
jgwest
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, thanks @shmurata , and thanks for your patience 😅 .
Thanks for this ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new generator proposed at #210 has been implemented as a Pull Request Generator.
Although the Pull Request Generator is similar to the SCM Provider Generator in some aspects, it seems that various changes are necessary to incorporate it into the SCM Provider Generator, so I have implemented it as a separate generator.
In the future, it may be possible to merge them.
I've implemented it to add other providers as well, but this PR only supports Github.
I can't implement other providers because I don't use them.
The requeue interval is polled in this PR, but I'd like to add webhook support to this generator after #341 is merged.