Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare results of geopandas with Arcgis #13

Closed
6 tasks done
lingyielia opened this issue Jan 6, 2018 · 6 comments
Closed
6 tasks done

Compare results of geopandas with Arcgis #13

lingyielia opened this issue Jan 6, 2018 · 6 comments
Labels

Comments

@lingyielia
Copy link
Collaborator

lingyielia commented Jan 6, 2018

Perform the overlay task on Arcgis with the same data we used here to double check our result.

How to submit an issue?

  • Have you checked previously open/closed issues to see if your question has already been asked & addressed?
    • If there is an open issue similar to your issue. Comment on that open issue with additional detail indicating that you too are having the same issue. This allows the project sponsor to prioritize incoming issues.
  • Have you provided a clear description of your issue so that the project sponsor is able to answer all your questions with as few back-n-forths as possible?
  • (Please acknowledge by checking this box) If a screenshot or visual helps better communicate some complex idea, have you provided one?. Draw.io and lucidchart are some excellent and quick drawing tools.
  • (Please acknowledge by checking this box) When an issue is resolved, please post the steps to resolution or clearly describe the resolution before marking the issue closed.
    • This will help future SOLVERS read through how your issue was solved and may help them solve their issue quicker.
  • Have you been kind, courteous, and considerate in your questions?
  • Have you considered using Stackedit.io, a handy tool to quickly write in markdown?
@lingyielia lingyielia added the TODO label Jan 6, 2018
@lingyielia
Copy link
Collaborator Author

screen shot 2018-01-07 at 3 42 53 pm

The result of spatial_overlay is not exactly the same as the result generated from Arcgis. I found some similar concerns regarding doing overlay on large datasets.

Do you think this difference is acceptable?

@lingyielia lingyielia changed the title Compare results of geopandas with Arcgis and Qgis Compare results of geopandas with Arcgis Jan 8, 2018
@vr00n
Copy link
Member

vr00n commented Jan 8, 2018

Thanks @lingyielia - please prepare to demonstrate this on our next meeting.

@vr00n vr00n added the Meeting label Jan 8, 2018
@lingyielia
Copy link
Collaborator Author

Compare the performance of spatial_overlay, qgis, and arcgis

  • Algorithm: spatial_overlay = qgisarcgis
  • Speed: arcgis > spatial_overlay = qgis
  • How they deal with 'invalid geometries': arcgis (handled somehow by itself), spatial_overlay (set a buffer of 0 to make the geometries valid), qgis (throw error)

For more information, see the discussion at the end of here.

@gauravcusp gauravcusp mentioned this issue Jan 13, 2018
6 tasks
@vr00n
Copy link
Member

vr00n commented Jan 13, 2018

Closed because this is beyond scope of this particular project but something that we need to look at in the future

@vr00n vr00n closed this as completed Jan 13, 2018
@lingyielia
Copy link
Collaborator Author

@vr00n , These are Data with Invalid Geometries. If you need any further information, please let me know.

@patwater
Copy link
Contributor

Hi team any objections to closing this issue? Doing some housekeeping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants