Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Avoid using passlib as argilla-server dependency #5664

Closed
frascuchon opened this issue Nov 4, 2024 · 0 comments · Fixed by #5674
Closed

[REFACTOR] Avoid using passlib as argilla-server dependency #5664

frascuchon opened this issue Nov 4, 2024 · 0 comments · Fixed by #5674
Assignees
@frascuchon
Labels
area: server Indicates that an issue or pull request is related to the server
Milestone
v2.5.0

Comments

@frascuchon
Copy link
Member 

          `passlib` is unmaintained. Maybe we should remove it and use `bcrypt` directly. Not sure if it's an easy change or not.

Related issue: pyca/bcrypt#684

Originally posted by @jfcalvo in #5649 (comment)
@frascuchon frascuchon self-assigned this Nov 4, 2024
@frascuchon frascuchon added the area: server Indicates that an issue or pull request is related to the server label Nov 4, 2024
This was referenced Nov 4, 2024
Merged
Merged
@frascuchon frascuchon added this to the v2.5.0 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frascuchon frascuchon

Labels
area: server Indicates that an issue or pull request is related to the server
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging a pull request may close this issue.

[REFACTOR] argilla server: Remove passlib dependency argilla-io/argilla
1 participant
@frascuchon