-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CONFIG] Resolve python requirements for python version and dependencies with server. #4935
Comments
>=3.10
-> >=3.9, <3.13
Already defined in the SDK
The server should be adapted to use pydantyc v2 which is not an evident task. Not sure if we can tackle this for v2. |
@jfcalvo Do you think you could tackle this one? |
I can take a look for sure. |
As @frascuchon commented we can change Python versions but we will still have problems with I have used From
From
|
Thanks @jfcalvo. How feasible would it be to upgrade the server to pydantic v2? Pydantic v1 features are exposed via the v2 api: https://docs.pydantic.dev/latest/migration/#continue-using-pydantic-v1-features @frascuchon explored this before we deprecated the argilla api v1 endpoints. Maybe it's easier now... |
@burtenshaw It's something we can explore but not sure if it will be possible inside the schedule with have for releasing v2.0. |
Thanks @jfcalvo. Using pydantic v1 from v2 wouldn't be a problem. The problem is using those with FastAPI which expects v2 models. We need to migrate all the schemas at once. (it would be nice if we could migrate endpoints iteratively, but it's not possible). Several changes imply a deep endpoint revision:
These changes and probably some more would be a potential nest of bugs if we don't take the time to validate everything. |
Thanks @frascuchon. It's useful to have that transition written out. What would you suggest for this issue then? |
@jfcalvo @frascuchon As discussed, it's not feasible to solve this within the current time frame, and there's minimal value to the end user because they can run server and client in docker of spaces. Therefore, we should solve this outside of implementation by adding detailed docs with warnings that make it clear that the server and sdk cannot be run in the same python env due to a pydantic conflict. We could support this further by checking the metrics on python server users, remove server dependence in @nataliaElv We can focus on this v2.2. |
No description provided.
The text was updated successfully, but these errors were encountered: