Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demand table should allow for a user-defined future #9

Open
samgdotson opened this issue Jun 10, 2021 · 0 comments
Open

Demand table should allow for a user-defined future #9

samgdotson opened this issue Jun 10, 2021 · 0 comments
Assignees
Labels
Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Comp:Input This issue has to do with the input component of the code or document. (input parameters, prep) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:3-Desired This work is important, but not urgent. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Feature New feature or feature request

Comments

@samgdotson
Copy link
Collaborator

Current behavior:

With DemandCommodity.add_demand(), users specify:

  • initial demand (or "seed")
  • growth rate
  • growth method (linear, exponential, or logistic)

Desired behavior:

With DemandCommodity.add_demand(), users should ALSO be able to specify
the demand for each year rather than have the demand calculated automatically.
E.g.

init_demand=[100, 100, 100, 150, 150, 125]...

Rather than specifying a single number for the first year, an array/list of values were given.
These values would never be calculated by any method available, but represents a future where demand
suddenly skyrockets and then falls back down. Perhaps a future where everything is suddenly electrified followed
by significant development in efficiency in subsequent decades.

Guidance:

In commodity.py the DemandCommodity.add_demand() method should be updated with a conditional argument checking the type of the init_demand variable. If the type is a float or integer, the future should be calculated as it is now. If it's a list or an array, then the demand should simply be stored in the commodity demand dictionary. In the latter case, the length of the list should also be checked against the number of years specified by the user. They must match.

@samgdotson samgdotson added Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Comp:Input This issue has to do with the input component of the code or document. (input parameters, prep) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:3-Desired This work is important, but not urgent. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Feature New feature or feature request labels Jun 10, 2021
@samgdotson samgdotson self-assigned this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Comp:Input This issue has to do with the input component of the code or document. (input parameters, prep) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:3-Desired This work is important, but not urgent. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Feature New feature or feature request
Projects
None yet
Development

No branches or pull requests

1 participant