Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to define a time horizon for a demand commdity #10

Open
samgdotson opened this issue Jun 10, 2021 · 1 comment
Open

Add the option to define a time horizon for a demand commdity #10

samgdotson opened this issue Jun 10, 2021 · 1 comment
Assignees
Labels
Comp:Input This issue has to do with the input component of the code or document. (input parameters, prep) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:3-Desired This work is important, but not urgent. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Feature New feature or feature request

Comments

@samgdotson
Copy link
Collaborator

Current behavior:

Demand commodities are defined with the DemandCommodity object and initialized for a new region with DemandCommodity.add_demand(). When users call .add_demand() they must supply

  • region
  • initial demand
  • start year
  • end year
  • number of years

Also, if users set up a distribution for a particular demand, users need to call DemandCommodity.set_distribution() and further specify

  • number of seasons
  • number of hours

Desired behavior:
In order to simplify the input, users should be able to optionally initialize a commodity time horizon. This will be helpful when users add many regions. In other words, users should be able to call set_timehorizon() to specify this information once, since it will be the same across all commodities in a simulation.

# old behavior
DemandCommodity.add_demand(region='place', init_demand=500, start_year=start_year, end_year=end_year, n_years=N_years)

# requested behavior
DemandCommodity.set_timehorizon(start_year, end_year, n_years, n_seasons, n_hours)
DemandCommodity.add_demand(region='place', init_demand=500)

Guidance:

add_demand should check if the time horizon information has already been instantiated. If it has not been, and users have not specified it in add_demand an error should be thrown.

@samgdotson samgdotson added Comp:Input This issue has to do with the input component of the code or document. (input parameters, prep) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:3-Desired This work is important, but not urgent. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Feature New feature or feature request labels Jun 10, 2021
@nsryan2
Copy link
Member

nsryan2 commented Jul 23, 2021

Is some of this issue (like the hours and seasons stuff) taken care of by the set_distribution function in the commodity script?

@nsryan2 nsryan2 self-assigned this Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp:Input This issue has to do with the input component of the code or document. (input parameters, prep) Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:3-Desired This work is important, but not urgent. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Feature New feature or feature request
Projects
None yet
Development

No branches or pull requests

2 participants