Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

so140 for persistent mqtt session #15530

Merged
merged 1 commit into from
May 4, 2022
Merged

Conversation

barbudor
Copy link
Contributor

@barbudor barbudor commented May 3, 2022

Description:

Related issue (if applicable): fixes #15519

SetOption140 0 : Open clean mqtt session (default)
SetOption140 1 : Open persistent mqtt session

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.3
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst arendst merged commit 070f24a into arendst:development May 4, 2022
@DetlefR
Copy link

DetlefR commented May 4, 2022

Hello,
unfortunately, it doesn't work. Whatever I set for MQTT_CLEAN_SESSION during build, SetOption140 has no effect. Also not after reboot or power on/off.

@barbudor
Copy link
Contributor Author

barbudor commented May 4, 2022

hum,
checking...

@barbudor
Copy link
Contributor Author

barbudor commented May 4, 2022

I can confirm that with SetOption140 OFF, the connection is perform with CLEAN_SESSION as before
And with SetOption140 ON, the connection is left persistent
Are you sure that you have the latest build ?

@DetlefR
Copy link

DetlefR commented May 5, 2022

Sorry,
my mistake. Due to my poor skills with git I had two versions off Tasmota.
Now it is working as expected. so140=>0 creates one volatile queue. And so140=>1 creates a second one which is persistent.

But keep in mind. You must add the subscription manually for the persistent queue.
Thank you.

@barbudor
Copy link
Contributor Author

barbudor commented May 5, 2022

But keep in mind. You must add the subscription manually for the persistent queue.

I beleve this is broker specific ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants