From 4bd48db9a5308e408b1c38390a7d29c80b2a8905 Mon Sep 17 00:00:00 2001 From: per1234 Date: Sun, 19 Dec 2021 21:13:28 -0800 Subject: [PATCH] Use major version ref of `carlosperate/download-file-action` The `carlosperate/download-file-action` action is used in the GitHub Actions workflows as a convenient way to download external resources. A major version ref has been added to that repository. It will always point to the latest release of the "1" major version series. This means it is no longer necessary to do a full pin of the action version in use as before. Use of the major version ref will cause the workflow to use a stable version of the action, while also benefiting from ongoing development to the action up until such time as a new major release of an action is made. At that time we would need to evaluate whether any changes to the workflow are required by the breaking change that triggered the major release before manually updating the major ref (e.g., uses: `carlosperate/download-file-action@v2`). I think this approach strikes the right balance between stability and maintainability for these workflows. --- .github/workflows/check-taskfiles.yml | 2 +- .github/workflows/sync-labels.yml | 4 ++-- workflow-templates/check-taskfiles.yml | 2 +- .../.github/workflows/check-taskfiles.yml | 2 +- .../.github/workflows/release-tag.yml | 2 +- .../.github/workflows/sync-labels.yml | 4 ++-- workflow-templates/release-tag.yml | 2 +- workflow-templates/sync-labels.yml | 4 ++-- 8 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/check-taskfiles.yml b/.github/workflows/check-taskfiles.yml index 45e306ab..11ed9cfa 100644 --- a/.github/workflows/check-taskfiles.yml +++ b/.github/workflows/check-taskfiles.yml @@ -36,7 +36,7 @@ jobs: - name: Download JSON schema for Taskfiles id: download-schema - uses: carlosperate/download-file-action@v1.0.3 + uses: carlosperate/download-file-action@v1 with: # See: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/taskfile.json file-url: https://json.schemastore.org/taskfile.json diff --git a/.github/workflows/sync-labels.yml b/.github/workflows/sync-labels.yml index fe53570f..3ee6febd 100644 --- a/.github/workflows/sync-labels.yml +++ b/.github/workflows/sync-labels.yml @@ -31,7 +31,7 @@ jobs: - name: Download JSON schema for labels configuration file id: download-schema - uses: carlosperate/download-file-action@v1.0.3 + uses: carlosperate/download-file-action@v1 with: file-url: https://raw.githubusercontent.com/arduino/tooling-project-assets/main/workflow-templates/assets/sync-labels/arduino-tooling-gh-label-configuration-schema.json location: ${{ runner.temp }}/label-configuration-schema @@ -65,7 +65,7 @@ jobs: steps: - name: Download - uses: carlosperate/download-file-action@v1.0.3 + uses: carlosperate/download-file-action@v1 with: file-url: https://raw.githubusercontent.com/arduino/tooling-project-assets/main/workflow-templates/assets/sync-labels/${{ matrix.filename }} diff --git a/workflow-templates/check-taskfiles.yml b/workflow-templates/check-taskfiles.yml index 45e306ab..11ed9cfa 100644 --- a/workflow-templates/check-taskfiles.yml +++ b/workflow-templates/check-taskfiles.yml @@ -36,7 +36,7 @@ jobs: - name: Download JSON schema for Taskfiles id: download-schema - uses: carlosperate/download-file-action@v1.0.3 + uses: carlosperate/download-file-action@v1 with: # See: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/taskfile.json file-url: https://json.schemastore.org/taskfile.json diff --git a/workflow-templates/dependabot/workflow-template-copies/.github/workflows/check-taskfiles.yml b/workflow-templates/dependabot/workflow-template-copies/.github/workflows/check-taskfiles.yml index 45e306ab..11ed9cfa 100644 --- a/workflow-templates/dependabot/workflow-template-copies/.github/workflows/check-taskfiles.yml +++ b/workflow-templates/dependabot/workflow-template-copies/.github/workflows/check-taskfiles.yml @@ -36,7 +36,7 @@ jobs: - name: Download JSON schema for Taskfiles id: download-schema - uses: carlosperate/download-file-action@v1.0.3 + uses: carlosperate/download-file-action@v1 with: # See: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/taskfile.json file-url: https://json.schemastore.org/taskfile.json diff --git a/workflow-templates/dependabot/workflow-template-copies/.github/workflows/release-tag.yml b/workflow-templates/dependabot/workflow-template-copies/.github/workflows/release-tag.yml index 130045b2..89a23357 100644 --- a/workflow-templates/dependabot/workflow-template-copies/.github/workflows/release-tag.yml +++ b/workflow-templates/dependabot/workflow-template-copies/.github/workflows/release-tag.yml @@ -36,7 +36,7 @@ jobs: - name: Download semver tool id: download-semver-tool - uses: carlosperate/download-file-action@v1.0.3 + uses: carlosperate/download-file-action@v1 with: file-url: https://github.com/fsaintjacques/semver-tool/archive/${{ env.SEMVER_TOOL_VERSION }}.zip location: ${{ runner.temp }}/semver-tool diff --git a/workflow-templates/dependabot/workflow-template-copies/.github/workflows/sync-labels.yml b/workflow-templates/dependabot/workflow-template-copies/.github/workflows/sync-labels.yml index fe53570f..3ee6febd 100644 --- a/workflow-templates/dependabot/workflow-template-copies/.github/workflows/sync-labels.yml +++ b/workflow-templates/dependabot/workflow-template-copies/.github/workflows/sync-labels.yml @@ -31,7 +31,7 @@ jobs: - name: Download JSON schema for labels configuration file id: download-schema - uses: carlosperate/download-file-action@v1.0.3 + uses: carlosperate/download-file-action@v1 with: file-url: https://raw.githubusercontent.com/arduino/tooling-project-assets/main/workflow-templates/assets/sync-labels/arduino-tooling-gh-label-configuration-schema.json location: ${{ runner.temp }}/label-configuration-schema @@ -65,7 +65,7 @@ jobs: steps: - name: Download - uses: carlosperate/download-file-action@v1.0.3 + uses: carlosperate/download-file-action@v1 with: file-url: https://raw.githubusercontent.com/arduino/tooling-project-assets/main/workflow-templates/assets/sync-labels/${{ matrix.filename }} diff --git a/workflow-templates/release-tag.yml b/workflow-templates/release-tag.yml index 130045b2..89a23357 100644 --- a/workflow-templates/release-tag.yml +++ b/workflow-templates/release-tag.yml @@ -36,7 +36,7 @@ jobs: - name: Download semver tool id: download-semver-tool - uses: carlosperate/download-file-action@v1.0.3 + uses: carlosperate/download-file-action@v1 with: file-url: https://github.com/fsaintjacques/semver-tool/archive/${{ env.SEMVER_TOOL_VERSION }}.zip location: ${{ runner.temp }}/semver-tool diff --git a/workflow-templates/sync-labels.yml b/workflow-templates/sync-labels.yml index fe53570f..3ee6febd 100644 --- a/workflow-templates/sync-labels.yml +++ b/workflow-templates/sync-labels.yml @@ -31,7 +31,7 @@ jobs: - name: Download JSON schema for labels configuration file id: download-schema - uses: carlosperate/download-file-action@v1.0.3 + uses: carlosperate/download-file-action@v1 with: file-url: https://raw.githubusercontent.com/arduino/tooling-project-assets/main/workflow-templates/assets/sync-labels/arduino-tooling-gh-label-configuration-schema.json location: ${{ runner.temp }}/label-configuration-schema @@ -65,7 +65,7 @@ jobs: steps: - name: Download - uses: carlosperate/download-file-action@v1.0.3 + uses: carlosperate/download-file-action@v1 with: file-url: https://raw.githubusercontent.com/arduino/tooling-project-assets/main/workflow-templates/assets/sync-labels/${{ matrix.filename }}