From 61d3e5fd040262162a74e29678da0f53265f2ae5 Mon Sep 17 00:00:00 2001 From: easyas314159 Date: Wed, 22 Sep 2021 14:59:11 -0600 Subject: [PATCH] Fix an incorrect use of TrimRight that should be a TrimSuffix. TrimRight greedily removes as any matching characters from the cutset as possible which can inadvertently remove characters from the library name. --- arduino/libraries/librariesmanager/install.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arduino/libraries/librariesmanager/install.go b/arduino/libraries/librariesmanager/install.go index 3600739b05f..776d5b207bd 100644 --- a/arduino/libraries/librariesmanager/install.go +++ b/arduino/libraries/librariesmanager/install.go @@ -245,12 +245,12 @@ func parseGitURL(gitURL string) (string, error) { if strings.HasPrefix(gitURL, "git@") { // We can't parse these as URLs i := strings.LastIndex(gitURL, "/") - res = strings.TrimRight(gitURL[i+1:], ".git") + res = strings.TrimSuffix(gitURL[i+1:], ".git") } else if path := paths.New(gitURL); path.Exist() { res = path.Base() } else if parsed, err := url.Parse(gitURL); err == nil { i := strings.LastIndex(parsed.Path, "/") - res = strings.TrimRight(parsed.Path[i+1:], ".git") + res = strings.TrimSuffix(parsed.Path[i+1:], ".git") } else { return "", fmt.Errorf(tr("invalid git url")) }