Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--zip-path cannot be enabled #2634

Closed
3 tasks done
dcrookston opened this issue Jun 12, 2024 · 1 comment
Closed
3 tasks done

--zip-path cannot be enabled #2634

dcrookston opened this issue Jun 12, 2024 · 1 comment
Assignees
Labels
conclusion: invalid Issue/PR not valid topic: CLI Related to the command line interface type: imperfection Perceived defect in any part of project

Comments

@dcrookston
Copy link

Describe the problem

$ arduino-cli lib install --zip-path ~/src/arduinolibs/libraries/crypto.zip
--git-url and --zip-path are disabled by default, for more information see: https://arduino.github.io/arduino-cli/0.35/configuration/#configuration-keys

I went to that URL and there is nothing about the setting to enable --zip-path. I searched and found this article:

https://forum.arduino.cc/t/arduino-cli-library-installing-error-enable-unsafe-install-is-false/867734

which says to set ARDUINO_LIBRARY_ENABLE_UNSAFE_INSTALL. This was already set, but I tried it anyway:

$ set ARDUINO_LIBRARY_ENABLE_UNSAFE_INSTALL=true
$ arduino-cli lib install --zip-path ~/src/arduinolibs/libraries/crypto.zip
--git-url and --zip-path are disabled by default, for more information see: https://arduino.github.io/arduino-cli/0.35/configuration/#configuration-keys

So either the error message, or the documentation, or the code, are wrong.

To reproduce

Install literally anything using the --zip-path flag.

Expected behavior

It should accept the path I gave it using --zip-path.

Arduino CLI version

0.35.3 Commit: 95cfd65 Date: 2024-02-19T13:24:25Z

Operating system

Linux

Operating system version

Linux raspberrypi 6.6.28+rpt-rpi-v8 #1 SMP PREEMPT Debian 1:6.6.28-1+rpt1 (2024-04-22) aarch64 GNU/Linux

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the nightly build
  • My report contains all necessary details
@dcrookston dcrookston added the type: imperfection Perceived defect in any part of project label Jun 12, 2024
@per1234 per1234 self-assigned this Jun 12, 2024
@per1234
Copy link
Contributor

per1234 commented Jun 12, 2024

Hi @dcrookston. The person being supported in that forum topic was a Windows user, so the information shared there was specific to Windows cmd. The set command is used to define environment variables in Windows cmd, but on Linux the command of that name has a completely different purpose so if you follow those instructions on a Linux machine the environment variable will not be defined.

On Linux, you must use this command:

export ARDUINO_LIBRARY_ENABLE_UNSAFE_INSTALL=true

Reference:

https://www.man7.org/linux/man-pages/man1/export.1p.html

The methods for defining the configuration key environment variables is already documented in the Arduino CLI configuration documentation:

https://arduino.github.io/arduino-cli/dev/configuration/#environment-variables

So I don't think any action is needed to address this issue (we should add coverage for PowerShell since that has become the primary shell on Windows, but that is a different subject).

@per1234 per1234 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2024
@per1234 per1234 added conclusion: invalid Issue/PR not valid topic: CLI Related to the command line interface labels Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: CLI Related to the command line interface type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

2 participants