Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The core.GetPlatforms function ignores the all field showing manually installed cores #1520

Closed
umbynos opened this issue Oct 19, 2021 · 5 comments
Closed

The core.GetPlatforms function ignores the all field showing manually installed cores #1520

umbynos opened this issue Oct 19, 2021 · 5 comments
Assignees
@umbynos
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@umbynos
Copy link
Contributor

umbynos commented Oct 19, 2021

The core.GetPlatforms function is not working as intended right now but the logic of this function is good.
It ignores the All field in the rpc.PlatformListRequest showing the manually installed cores even if the All field is set to false.
see #1509 (comment)
@umbynos umbynos added topic: code Related to content of the project itself type: bug labels Oct 19, 2021
@umbynos umbynos self-assigned this Oct 19, 2021
@per1234 per1234 added type: imperfection Perceived defect in any part of project and removed type: bug labels Oct 19, 2021
@umbynos umbynos mentioned this issue Oct 19, 2021
Closed
5 tasks
@4ntoine
Copy link
Contributor

4ntoine commented Oct 21, 2021

It seems to be the bug i've faced with too. If starting from scratch (or data dir cleaned): core list --all forces updating index (library_index, package_index) but GetPlatform with all passed called via gRPC just returns an empty list.

@4ntoine
Copy link
Contributor

4ntoine commented Oct 21, 2021

Nope, it seems that all is used in the code. I will create another ticket for my issue

@fstasi fstasi added this to the arduino-cli 0.22.0 milestone Jan 25, 2022
@ubidefeo
Copy link

ubidefeo commented Apr 6, 2022

@umbynos @4ntoine
can we assume this is a closed issue in light of #1521 being merged?

@umbynos
Copy link
Contributor Author

umbynos commented Apr 11, 2022

Actually that PR is not merged yet because the tests are not passing. It surely need some more investigation

@per1234 per1234 linked a pull request Apr 11, 2022 that will close this issue
fix GetPlatform function ignoring the All field #1521
Closed
5 tasks
@umbynos umbynos removed this from the arduino-cli 0.22.0 milestone May 9, 2022
@alessio-perugini
Copy link
Contributor

Fixed in: #2357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@umbynos umbynos

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix GetPlatform function ignoring the All field arduino/arduino-cli
6 participants
@4ntoine @fstasi @ubidefeo @alessio-perugini @per1234 @umbynos