From ec5c3ed105b32c5654fd60131a667f8557b196d5 Mon Sep 17 00:00:00 2001 From: Roberto Sora Date: Thu, 16 Apr 2020 16:08:45 +0200 Subject: [PATCH] Fix serial port URI parsing in board attach command (#661) --- commands/board/attach.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/commands/board/attach.go b/commands/board/attach.go index 488779e81d5..5dc5bb7427f 100644 --- a/commands/board/attach.go +++ b/commands/board/attach.go @@ -112,7 +112,10 @@ func Attach(ctx context.Context, req *rpc.BoardAttachReq, taskCB commands.TaskPr // for the matching. func findSerialConnectedBoard(pm *packagemanager.PackageManager, monitor *discovery.Monitor, deviceURI *url.URL) *cores.Board { found := false - location := deviceURI.Path + // to support both cases: + // serial:///dev/ttyACM2 parsing gives: deviceURI.Host = "" and deviceURI.Path = /dev/ttyACM2 + // serial://COM3 parsing gives: deviceURI.Host = "COM3" and deviceURI.Path = "" + location := deviceURI.Host + deviceURI.Path var serialDevice discovery.SerialDevice for _, device := range monitor.Serial() { if device.Port == location {