Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some samd variants are missing SDA and SCL symbols #473

Closed
bperrybap opened this issue Nov 30, 2019 · 0 comments · Fixed by #486
Closed

Some samd variants are missing SDA and SCL symbols #473

bperrybap opened this issue Nov 30, 2019 · 0 comments · Fixed by #486
Assignees
@Rocketct

Comments

@bperrybap
Copy link

bperrybap commented Nov 30, 2019 •
edited
Loading

Some of the variants are missing SDA and SCL symbols in the associated variant.h header file.
These variants are missing the symbols:

  • mkrfox1200
  • mkrgsm1300
  • mkrwan1400
  • mkrzero

The other variants handle this by creating some constants:

static const uint8_t SDA = PIN_WIRE_SDA;
static const uint8_t SCL = PIN_WIRE_SCL;

Just after the PIN_WIRE_SDA and PIN_WIRE_SDA defines

The lack of these base/required symbols causes some arduino sketch/library s/w to fail to compile.
Rocketct added a commit to Rocketct/ArduinoCore-samd that referenced this issue Jan 15, 2020
@Rocketct
Added SDA and SCL variables
cb01df8 
added SDA and SCL variable in each samd variant.h

this fix: arduino#473
Rocketct added a commit to Rocketct/ArduinoCore-samd that referenced this issue Jan 15, 2020
@Rocketct
added SDA and SCL Variables
1c00260 
Added SDA and SCL variables in variant.h of samd boards

This resolve: arduino#473
@Rocketct Rocketct mentioned this issue Jan 15, 2020
Merged
Rocketct added a commit that referenced this issue Jan 17, 2020
@Rocketct
added SDA and SCL Variables
ccfcc89 
Added SDA and SCL variables in variant.h of samd boards

This resolve: #473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rocketct Rocketct

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added SDA and SCL Variables Rocketct/ArduinoCore-samd
2 participants
@bperrybap @Rocketct