SocketWrapper lib Client setConnectionTimeout added #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and timeout applied for connect
JAndrassy
force-pushed
the
mbedclient_conn_timeout
branch
from
cabeaf8 to
f0cb2a6
Compare
|
closing, because the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #769 I wrote in a comment
reading the Mbed TCPSocket.cpp source, I see that this is not true and Mbed uses that timeout in
connect. Sorry. My mistake was my assumption that it works the same way as in LwIP, but Mbed adds some logic as it wraps LwIP.this PR adds setConnectionTimeout as alias to setSocketTimeout and sets the timeout before
connectthis timeout is now applied in MbedClient in
connect,stopandwrite.readshouldn't block in Arduino API so inreadthe timeout is not used.