-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AE-2] Add zoom, flip, and mirror functionality for GC2145 #689
Merged
Commits on May 26, 2023
-
Add zoom, flip, and mirror functionality
Adds the functions zoomTo(), zoomToCenter(), setVerticalFlip(), setHorizontalMirror(), getResolutionWidth(), and getResolutionHeight() to the Camera library. The old setResolution() function is changed into the new private function setResolutionWithZoom(), which is called by the new version of setResolution(), as well as by the zoomTo() and zoomToCenter() functions. These changes required some changes in the abstract class ImageSensor, which, in turn, required further changes in the camera drivers. The only camera driver that fully supports the new functionality is GC2145, and the others return -1 on all calls. The function signature for setResolution() is changed, and two new functions are added: setVerticalFlip() and setHorizontalMirror().
Configuration menu - View commit details
-
Copy full SHA for 4a46b58 - Browse repository at this point
Copy the full SHA 4a46b58View commit details -
Change parameter names for flipping and mirroring
The parameter names are changed from _mode to _enable.
Configuration menu - View commit details
-
Copy full SHA for a6a013a - Browse repository at this point
Copy the full SHA a6a013aView commit details -
Separate setResolutionWithZoom() and setResolution()
Adds back the setResolution() function to the camera drivers by calling setResolutionWithZoom() with default parameters.
Configuration menu - View commit details
-
Copy full SHA for 36fd82b - Browse repository at this point
Copy the full SHA 36fd82bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 060ff9d - Browse repository at this point
Copy the full SHA 060ff9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6deae7f - Browse repository at this point
Copy the full SHA 6deae7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1632762 - Browse repository at this point
Copy the full SHA 1632762View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5eda61d - Browse repository at this point
Copy the full SHA 5eda61dView commit details -
Configuration menu - View commit details
-
Copy full SHA for df134fd - Browse repository at this point
Copy the full SHA df134fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c42b18 - Browse repository at this point
Copy the full SHA 7c42b18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 936228d - Browse repository at this point
Copy the full SHA 936228dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b713cb - Browse repository at this point
Copy the full SHA 6b713cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb7ec81 - Browse repository at this point
Copy the full SHA cb7ec81View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.