Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

architectures in library.properties inaccurate #31

Closed
TheNitek opened this issue Mar 11, 2017 · 2 comments
Closed

architectures in library.properties inaccurate #31

TheNitek opened this issue Mar 11, 2017 · 2 comments

Comments

@TheNitek
Copy link

library.properties states architectures=* which makes my Arduino IDE choose it over the SD lib included in the esp8266 board package.
This would not be a problem, if Sd2PinMap.h did not contain
#error Architecture or board not supported.
which breaks my build. So I guess the architectures declaration should be more specific.

@cmaglie
Copy link
Contributor

cmaglie commented Nov 23, 2017

I've added the definitions 9543f55

BTW I think that the SD lib provided by the ESP8266 core should have the architecture field set as well https://github.com/esp8266/Arduino/blob/7b09ae5f69f8dccb5152d128c8484ec9a18adb11/libraries/SD/library.properties#L9
I'll open an issue over there.

@Dravon5X
Copy link

Dravon5X commented Dec 4, 2017

this fix actually produce a bug, that every one user of arudino IDE is receiving notification after IDE start that update is available for SD library, but there is nothing to update. SD library is also always under Updateable libraries. Please revert and find a different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants