Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make single error instance of Error to prevent [object Object] error messages #1048

Closed
wants to merge 5 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Jan 22, 2019

A fix for #1046

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

@apollo-cla
Copy link

@almostprogrammer: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@ghost ghost requested review from benjamn and hwillson as code owners January 22, 2019 22:26
@ghost ghost changed the title Fix issue 1046 Make single error instance of Error to prevent [object Object] error messages Jan 24, 2019
@hwillson
Copy link
Contributor

Thanks for working on this @almostprogrammer. Are you able to look at the test failures? They seem relevant.

@ghost
Copy link
Author

ghost commented Jan 25, 2019

@hwillson a test that fails is not related to my fix. In fact it also fails in master

screenshot 2019-01-25 at 16 44 30

@shawnXiao
Copy link

shawnXiao commented Jan 29, 2019

I also have the same test failure.
Maybe the test case have some problem.
I search the GraphQL specification, there is no refer about the fragment with parameter.
I also have a look about GraphQL-JS source code, the problem which occur at validate the schema definition at the KnownTypeNames.js.
@hwillson
image

@kommander
Copy link

@almostprogrammer Awesome, I hope this gets through soon. I fixed this in graphqljs, but have to wait for 14.2 release https://github.com/graphql/graphql-js/pull/1600/files#diff-7216927a33b2b307f325a8190e6fbf9bR746

@fenos
Copy link

fenos commented Feb 12, 2019

Hi there,
Any progress on merging this? It's a vital fix that we are all waiting for 😄

@MrLoh
Copy link

MrLoh commented Feb 14, 2019

Would be great to see this merged

@fenos
Copy link

fenos commented Mar 11, 2019

mergy mergy 😄🙏

@MrLoh
Copy link

MrLoh commented Jul 1, 2019

Could this be merged, it's really annoying to depend on patch-package for such a stupid issue that already has a PR since 3 months.

@yaacovCR
Copy link
Collaborator

yaacovCR commented Jul 1, 2019

This should be fixed in graphql-tools-fork.

@yaacovCR
Copy link
Collaborator

yaacovCR commented Apr 1, 2020

Closing in favor of #1307

@yaacovCR yaacovCR closed this Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants