-
-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make single error instance of Error to prevent [object Object] error messages #1048
Conversation
…rror messages when schema stitching
@almostprogrammer: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Thanks for working on this @almostprogrammer. Are you able to look at the test failures? They seem relevant. |
@hwillson a test that fails is not related to my fix. In fact it also fails in master |
I also have the same test failure. |
@almostprogrammer Awesome, I hope this gets through soon. I fixed this in graphqljs, but have to wait for 14.2 release https://github.com/graphql/graphql-js/pull/1600/files#diff-7216927a33b2b307f325a8190e6fbf9bR746 |
Hi there, |
Would be great to see this merged |
mergy mergy 😄🙏 |
Could this be merged, it's really annoying to depend on patch-package for such a stupid issue that already has a PR since 3 months. |
This should be fixed in graphql-tools-fork. |
Closing in favor of #1307 |
A fix for #1046
TODO: