Delegating to remote schema does not forward identical query?

[kdojeteri]

I'm having trouble stitching my schema to my former API written in Youshido\GraphQL. There's been a bit of talk about this before. I found that I'm experiencing what's described in the first post of this issue: youshido-php/GraphQL#144 .

The schema is this:

type Query {
    Foo(uuid: String): String
}

I query my new endpoint like this:

query {
    Foo
}

Some process in graphql-tools, which I presume involves delegateToSchema, takes the received query and turns it into this:

query ($_uuid: String) {
    Foo(uuid: $_uuid)
}

--------
Variables:
{
    "_uuid": undefined
}

... Because JSON.stringify({a: undefined}) === '{}', the undefined variable definitions get thrown out, but the variable symbols stay in the query. Youshido\GraphQL then complains that it sees these variables, but no variable values to go along with them.

{"errors": [
    {"message": "Variable _uuid hasn't been submitted"}
]}

This is not a bug report, because I don't think it's clear if it's apollo/graphql-tools that need to be fixed, or Youshido\GraphQL. I personally think that if the variables are not included in the original query, they should not be in the forwarded one either. It all comes down to whether these four should be considered different or not:

query { Foo }
query { Foo(uuid: null) }
query ($_uuid: String) { Foo(uuid: $_uuid) } // variables: {}
query ($_uuid: String) { Foo(uuid: $_uuid) } // variables: {"_uuid": null}

---

Possibly related: #550

[freiksenet]

This is fixed with new variable generation in #527. It's WIP, but it should land this month and this problem should be fixed then.

[hwillson]

Fixed in #527 - thanks!