Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on fast-url-parser #5675

Closed
gajus opened this issue Oct 30, 2023 · 2 comments
Closed

Drop dependency on fast-url-parser #5675

gajus opened this issue Oct 30, 2023 · 2 comments

Comments

@gajus
Copy link

gajus commented Oct 30, 2023

As far as I can tell, this was added to support very old Node.js platforms and it currently pulls in some undesirable dependencies:

@graphql-codegen/cli 5.0.0
├─┬ @graphql-tools/apollo-engine-loader 8.0.0
│ └─┬ @whatwg-node/fetch 0.9.14
│   └─┬ @whatwg-node/node-fetch 0.5.0
│     └─┬ fast-url-parser 1.1.3
│       └── punycode 1.4.1

punycode in particular is flooding our logs with warnings:

contra-custom-profiles:test:vitest: (node:1255513) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
contra-custom-profiles:test:vitest: (Use `node --trace-deprecation ...` to show where the warning was created)
contra-custom-profiles:test:vitest: (node:1255513) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
contra-custom-profiles:test:vitest: (Use `node --trace-deprecation ...` to show where the warning was created)
contra-custom-profiles:test:vitest: (node:1255513) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.

Would happily submit a PR that drops fast-url-parser in favor of using URL.

@gajus
Copy link
Author

gajus commented Oct 30, 2023

Oh, it is coming from the @whatwg-node/fetch

@ardatan
Copy link
Owner

ardatan commented Oct 30, 2023

fast-url-parser is added for performance not to support older Node versions. Let's track issue in that repo.

@ardatan ardatan closed this as completed Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants