Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewireTypes should recreate types only when necessary #4464

Open
Tracked by #5201 ...
yaacovCR opened this issue May 18, 2022 · 1 comment
Open
Tracked by #5201 ...

rewireTypes should recreate types only when necessary #4464

yaacovCR opened this issue May 18, 2022 · 1 comment

Comments

@yaacovCR
Copy link
Collaborator

see graphql/graphql-js#3596 (comment)

mapSchema changes only the requested types, and then calls rewireTypes which unfortunately recreates ALL schema types. This ensures that all fields on all types are pointing to the new types, but it may often be overkill.

@yaacovCR
Copy link
Collaborator Author

basically, we would have to change rewireTypes to work in two stages, first to crawl the schema and determine what actually needs to be recreated, and then to iterate through that and recreate only what's necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant