-
-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove onTypeConflict from public api #1044
Comments
Please bring back As also noted in that thread multiple times, there are scenarios in which this feature seemingly cannot be substituted with schema transforms. How could I merge the values of two enum types for example? |
Agreed, since |
@nether-cat You would query the individual schemas and reconcile it before calling We were able to replace all our type conflict resolution with our own programmed with schema transforms. It's just not as friendly. What would have been nice is instead of removing the functionality if they wanted |
Brought back, rolled into #1306 |
As noted in this thread #863
The following change removed the usage of the parameter: https://github.com/apollographql/graphql-tools/pull/918/files#diff-bb87a5c1cf8e770e2b377a7e61904637L38
Would be good to remove from the public api so people don't think it actually does anything anymore.
The text was updated successfully, but these errors were encountered: