Cannot read properties of undefined (reading 'originalError')

[Flamefork]

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

• 1. The issue provides a reproduction available on
  Github,
  Stackblitz
  or
  CodeSandbox

Make sure to fork this template and run yarn generate in the terminal.

Please make sure Mesh package versions under package.json matches yours.

• 2. A failing test has been provided
• 3. A local solution has been provided
• 4. A pull request is pending review

---

Describe the bug

A real error being masked by an exception in graphql-yoga's result-processor if more than one source used.

Seems like the problem is caused by graphql-jit's own version of GraphQLError which could have (and having) undefined in extensions, while in a lot of places it is treated as non-nullable, as in graphql-js.

For some reason, this problem does not occur when only one source present.

#6059 looks like another instance of this bug, though the one I'm reporting reproduces with the latest mesh version, after the fix.

To Reproduce Steps to reproduce the behavior:

I've uploaded a gist inspired by @TomKlaverAH reproduction 🙏 :

https://gist.github.com/Flamefork/2f00268dfb31a2b27dca5c5fc1e1692d

You can run it in one go with docker using:

docker run -it --rm --entrypoint=/bin/bash node:18 -c 'curl -sL https://gist.github.com/Flamefork/2f00268dfb31a2b27dca5c5fc1e1692d/raw | bash -s'

Expected behavior

The scenario is intentionally erroneous, the problem is that the expected outcome of this erroneous request should be a proper error

HTTP/1.1 200 OK

{"errors": [
  {"message": "Variable \"$input\" got invalid value { bogus: \"Res\" }; Field value.text of required type String! was not provided."},
  {"message": "Variable \"$input\" got invalid value { bogus: \"Res\" }; Field \"bogus\" is not defined by type MutInput."}
]}

but instead mesh responds with a generic exception in a response processing code

HTTP/1.1 500 Internal Server Error

{"errors":[
  {"message":"Cannot read properties of undefined (reading 'originalError')"}
]}

(formatted responses a bit for readability)

[Flamefork]

Also related: dotansimha/graphql-yoga#2967

[dpnova]

I'm getting this with a swagger source behind mesh. Quite annoying as I end up getting a 500 from mesh, but the backend source worked fine.

[dpnova]

@Flamefork have you found a workaround for this?

In my case the backend rest API is not erroring, so it seems the only error is happening in mesh.

I tried bumping to the versions in this one #6059 but I'm still seeing the same issue.

This happens with a single source for me.

[ardatan]

Thanks for the details but could you please create a reproduction on CodeSandbox or StackBlitz instead of Docker?

[dpnova]

I've noticed other people with the same issue here: zalando-incubator/graphql-jit#234

@ardatan is there a way to just run without graphql-jit ?

[dxbrandon]

@ardatan I'm also running into issues where I'm receiving an undefined error for originalError. I reproduced a codesandbox here: https://codesandbox.io/p/sandbox/sad-poincare-lkhtjp

This is also my first time using codesandbox so hopefully there aren't any issues with the environment.

After running the command: yarn start, I opened postman and ran this somewhat invalid query:

Here's the request body that I ran:

{
    "operationName": "MyMutation",
    "query": "mutation MyMutation {update_test(input: {name: \" \"})}",
    "extensions": {}
}

Hopefully this helps resolve the issue.

[ardatan]

Unfortunately I am not able to reproduce it even if I installed the dependencies and updated the start script in package.json;
https://codesandbox.io/p/devbox/pedantic-shannon-h9tpgk?file=%2Fpackage.json%3A7%2C23

[ardatan]

Fixed in the upstream package;
dotansimha/graphql-yoga#3157