Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Function templates should be updated to use configurable serilog settings #480

Open
fgheysels opened this issue Dec 1, 2021 · 5 comments · May be fixed by #495
Open

Azure Function templates should be updated to use configurable serilog settings #480

fgheysels opened this issue Dec 1, 2021 · 5 comments · May be fixed by #495
Assignees
Labels
area:telemetry All issues related to telemetry enhancement New feature or request runtime:azure-functions All issues related to templates forAzure Functions
Milestone

Comments

@fgheysels
Copy link
Member

The templates that are used to quickly start an Azure Function project should be modified so that the Serilog configuration can be read from the configuration using LoggerConfiguration.ReadFrom.Configuration() just like we do in the Api template.

Next to that, we should also only log to AppInsights if the instrumentationkey is not blank.

@stijnmoreels stijnmoreels added area:telemetry All issues related to telemetry enhancement New feature or request runtime:azure-functions All issues related to templates forAzure Functions labels Dec 1, 2021
@stijnmoreels stijnmoreels added this to the v0.8.0 milestone Dec 1, 2021
@spasal
Copy link

spasal commented Dec 1, 2021

Sounds good, I would like to pick this up to start contributing on this repo. Ok?

@stijnmoreels
Copy link
Member

Sounds good, I would like to pick this up to start contributing on this repo. Ok?

Amazing! 🥳 That's really great of you. Let us know if you come across any issues.

@fgheysels
Copy link
Member Author

After creating this issue, and after a chat with @spasal , I am actually quite curious on how this will impact the built-in Function-logging stuff.

@stijnmoreels
Copy link
Member

After creating this issue, and after a chat with @spasal , I am actually quite curious on how this will impact the built-in Function-logging stuff.

We'll see 😄 . We can take a peak in the build log when the PR is there.

@stijnmoreels
Copy link
Member

stijnmoreels commented Aug 1, 2022

Will have to wait until Serilog compiles to the latest version: serilog/serilog-aspnetcore#245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:telemetry All issues related to telemetry enhancement New feature or request runtime:azure-functions All issues related to templates forAzure Functions
Projects
None yet
3 participants