Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve consistency in Powershell parameter-names #322

Closed
fgheysels opened this issue Aug 25, 2022 · 1 comment · Fixed by #324
Closed

Improve consistency in Powershell parameter-names #322

fgheysels opened this issue Aug 25, 2022 · 1 comment · Fixed by #324
Assignees
@pim-simons
Labels
area:api-management All issues related to Azure API Management bug Something isn't working good first issue Good for newcomers
Milestone
v0.7.0

Comments

@fgheysels
Copy link
Member

I have seen that most parameters in the Import-AzApiManagementApiPolicy script are PascalCased, however, one parameter is camelCased.
It would be better to make sure that the same convention is used :)

https://github.com/arcus-azure/arcus.scripting/blob/master/src/Arcus.Scripting.ApiManagement/Scripts/Import-AzApiManagementApiPolicy.ps1
@stijnmoreels
Copy link
Member

Woops. Thx for noting! 👍

@stijnmoreels stijnmoreels added this to the v0.7.0 milestone Aug 26, 2022
@stijnmoreels stijnmoreels added bug Something isn't working area:api-management All issues related to Azure API Management good first issue Good for newcomers labels Aug 26, 2022
@pim-simons pim-simons self-assigned this Aug 26, 2022
@pim-simons pim-simons mentioned this issue Aug 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pim-simons pim-simons

Labels
area:api-management All issues related to Azure API Management bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
v0.7.0
3 participants
@fgheysels @stijnmoreels @pim-simons