Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Copy-AzFileShareStorageFiles to Upload-AzFileShareStorageFiles #203

Closed
stijnmoreels opened this issue Jul 27, 2021 · 2 comments · Fixed by #205
Closed

Rename Copy-AzFileShareStorageFiles to Upload-AzFileShareStorageFiles #203

stijnmoreels opened this issue Jul 27, 2021 · 2 comments · Fixed by #205
Assignees
Labels
area:storage All issues related to Azure Storage enhancement New feature or request
Milestone

Comments

@stijnmoreels
Copy link
Member

stijnmoreels commented Jul 27, 2021

Is your feature request related to a problem? Please describe.
As the Azure Blob storage uses Upload-... for uploading raw blob contents, it seems more streamlined that we use that in the Azure File Share too.

Make sure that we mark it as obsolete, or write a warning when using the Copy-... in the next version.

@stijnmoreels stijnmoreels added enhancement New feature or request area:storage All issues related to Azure Storage labels Jul 27, 2021
@stijnmoreels stijnmoreels added this to the v0.5.0 milestone Jul 27, 2021
@mbraekman
Copy link
Contributor

Good thinking.
Perhaps let's do a phased approach?
Next release -> write a warning that Copy-... has become obsolete but still forwards the request to Upload-...
Later release -> Copy-... is actually removed

Makes it a bit more complex from a maintenance point of view, through.

@stijnmoreels
Copy link
Member Author

Yes, of course, gradually!👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:storage All issues related to Azure Storage enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants