Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for K6 performanceTests upload to Log Analytics #181

Open
MichielVanwelsenaere opened this issue Jun 22, 2021 · 4 comments
Open
Labels
area:log-analytics All issues related to Azure Log Analytics feature-suggestion All issues related suggestion of a new feature. These are nice to haves but not customer requests specs-required All issues where the specifications are still being defined and implementation should be halted
Milestone

Comments

@MichielVanwelsenaere
Copy link

MichielVanwelsenaere commented Jun 22, 2021

Is your feature request related to a problem? Please describe.
I've been using K6 on a project and quite like it. Unfortunately the CI/CD setup is a bit cumbersome (that is for processing the results at least). There's a K6 task for uploading the results to Application Insights but it requires a ClientSecet.

We've been using this script documented in this blogpost which is quite handy for upload to Log Analytics (and leverages the pipeline identity).

In addition, aside from an upload a good workbook template to visualize the results in Log Analytics and build in support for deploying it to Log Analytics would have quite some added value.

Describe the solution you'd like
One or two functions supporting upload to Log Analytics using pipeline identity with a parameter allowing a workbook template to be past to. A decent template example could be provided in the docs

Describe alternatives you've considered
Extending the K6 task or creating a new one for uploading results to Azure Log Analytics.

Additional context
Add any other context or screenshots about the feature request here.

@mbraekman
Copy link
Contributor

mbraekman commented Jun 22, 2021

If I understand your request well, it is actually 2-fold:

  • 1 script that in itself won't really have any relation to K6 specifically, as it is more related to uploading a workbook to Log Analytics?
  • 1 script to take the output from K6 and push that data into Log Analytics.

The following however probably is more K6-specific, but can be documented indeed:

A decent template example could be provided in the docs

Also, feel free to provide a decent/working template :)

@mbraekman mbraekman added feature-suggestion All issues related suggestion of a new feature. These are nice to haves but not customer requests specs-required All issues where the specifications are still being defined and implementation should be halted area:log-analytics All issues related to Azure Log Analytics labels Jun 22, 2021
@fgheysels
Copy link
Member

Just some input on uploading the results to App Insights:

You say that a client-secret is required, but is that such a problem ? You obviously don't want to have the client-secret in your pipeline, but you can have your client-secret stored in KeyVault and let your pipeline retrieve (and use) it.

@MichielVanwelsenaere
Copy link
Author

In our case this was a discussion with a dedicated platform team that I didn't attend so I can't really go into detail here. But as far as I know a client-secret was not an option.

I must honestly say that I understand, the alternative -the script- works fine and doesn't require a client-secret. I personally think that client-secrets should be avoided whenever possible. They can be leaked and can require periodic renewal.

@MichielVanwelsenaere
Copy link
Author

Also, feel free to provide a decent/working template :)

attached.
ARM_k6Workbook.zip

@stijnmoreels stijnmoreels added this to the v0.6.0 milestone Oct 28, 2021
@stijnmoreels stijnmoreels modified the milestones: v0.6.0, v0.7.0 Apr 1, 2022
@stijnmoreels stijnmoreels modified the milestones: v0.7.0, v0.8 Aug 26, 2022
@stijnmoreels stijnmoreels modified the milestones: v0.8.0, v0.9.0 Jan 10, 2023
@pim-simons pim-simons modified the milestones: v0.9.0, v1.0.0, v1.1.0 May 10, 2023
@stijnmoreels stijnmoreels modified the milestones: v1.1.0, v1.2.0 Jul 3, 2023
@pim-simons pim-simons modified the milestones: v1.2.0, v1.3.0 Nov 21, 2023
@stijnmoreels stijnmoreels modified the milestones: v1.3.0, v1.4.0 Jun 13, 2024
@pim-simons pim-simons modified the milestones: v1.4.0, v1.5.0 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:log-analytics All issues related to Azure Log Analytics feature-suggestion All issues related suggestion of a new feature. These are nice to haves but not customer requests specs-required All issues where the specifications are still being defined and implementation should be halted
Projects
None yet
Development

No branches or pull requests

5 participants