Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WithCorrelationInfo Serilog enrichment overload without `IServiceProvider #394

Closed
stijnmoreels opened this issue Jun 13, 2022 · 0 comments · Fixed by #540
Closed

Remove WithCorrelationInfo Serilog enrichment overload without `IServiceProvider #394

stijnmoreels opened this issue Jun 13, 2022 · 0 comments · Fixed by #540
Assignees
@stijnmoreels
Labels
breaking-change All issues that require to do a breaking chnage correlation All issues related to correlating telemetry enrichers All issues related to Serilog enrichers to automatically provide contextual information good first issue Good for newcomers serilog All issues related to Serilog
Milestone
v3.0.0

Comments

@stijnmoreels
Copy link
Member

Is your feature request related to a problem? Please describe.
Previously, we made sure that correlation is scoped, which means that the Serilog enrichment should also make use of scoped dependencies and those kinds are only available in the IServiceProvider.

Describe the solution you'd like
Remove the deprecated WithCorrelationInfo Serilog enrichment overload without the IServiceProvider in the Arcus.Observability.Telemetry.Serilog.Enrichers project.
@stijnmoreels stijnmoreels added good first issue Good for newcomers serilog All issues related to Serilog correlation All issues related to correlating telemetry enrichers All issues related to Serilog enrichers to automatically provide contextual information labels Jun 13, 2022
@stijnmoreels stijnmoreels added this to the v3.0.0 milestone Jun 13, 2022
@stijnmoreels stijnmoreels added the breaking-change All issues that require to do a breaking chnage label Jun 13, 2022
@stijnmoreels stijnmoreels modified the milestones: v3.0.0, v4.0.0 Sep 15, 2023
@stijnmoreels stijnmoreels self-assigned this Sep 29, 2023
@stijnmoreels stijnmoreels mentioned this issue Sep 29, 2023
Merged
@github-project-automation github-project-automation bot moved this to Done in Roadmap Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stijnmoreels stijnmoreels

Labels
breaking-change All issues that require to do a breaking chnage correlation All issues related to correlating telemetry enrichers All issues related to Serilog enrichers to automatically provide contextual information good first issue Good for newcomers serilog All issues related to Serilog
Projects
Roadmap
Status: Done
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

chore: remove deprecated correlation stijnmoreels/arcus.observability
1 participant
@stijnmoreels