Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete ContextProperties.EventTracking.EventContext #273

Closed
stijnmoreels opened this issue Jan 27, 2022 · 2 comments · Fixed by #550
Closed

Remove obsolete ContextProperties.EventTracking.EventContext #273

stijnmoreels opened this issue Jan 27, 2022 · 2 comments · Fixed by #550
Assignees
@stijnmoreels
Labels
breaking-change All issues that require to do a breaking chnage enhancement New feature or request good first issue Good for newcomers
Milestone
v3.0.0

Comments

@stijnmoreels
Copy link
Member

Is your feature request related to a problem? Please describe.
We have moved the telemetry context to ContextProperties.TelemetryContext, which makes the ContextProperties.EventTracking.EventContext obsolete.

Describe the solution you'd like
Remove the obsolete context property and related assignments when the log property is added to the Application Insights telemetry.
@stijnmoreels stijnmoreels added enhancement New feature or request good first issue Good for newcomers breaking-change All issues that require to do a breaking chnage labels Jan 27, 2022
@stijnmoreels stijnmoreels added this to the v3.0.0 milestone Jan 27, 2022
@dmallya
Copy link

dmallya commented Jan 28, 2022

Hi, could I work on this issue please?

@stijnmoreels
Copy link
Member Author

Hi, could I work on this issue please?

Great that you want to contribute! Super. This issue, however, is for when we release v3.0 which is still a lot in the future for now. See this list for any other good first issues to start with Arcus.
Thanks again for your enthusiasm! 🥇

@stijnmoreels stijnmoreels modified the milestones: v3.0.0, v4.0.0 Sep 15, 2023
@stijnmoreels stijnmoreels self-assigned this Nov 14, 2023
@stijnmoreels stijnmoreels mentioned this issue Nov 14, 2023
Merged
@github-project-automation github-project-automation bot moved this to Done in Roadmap Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stijnmoreels stijnmoreels

Labels
breaking-change All issues that require to do a breaking chnage enhancement New feature or request good first issue Good for newcomers
Projects
Roadmap
Status: Done
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

chore: remove obsolete app insights functionality stijnmoreels/arcus.observability
2 participants
@stijnmoreels @dmallya