Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update serde-yaml to 0.9 #30

Open
arcnmx opened this issue Mar 28, 2023 · 0 comments
Open

update serde-yaml to 0.9 #30

arcnmx opened this issue Mar 28, 2023 · 0 comments

Comments

@arcnmx
Copy link
Owner

arcnmx commented Mar 28, 2023

The update breaks configurations because of dtolnay/serde-yaml#342 - the suggestion may need to be used with a special with wrapper to work with Vec<Enum> and other container types 😞
(the better approach may be to bake it into the Deserialize impl somehow?)

The issue here is that with the update the config is no longer compatible with json parsed as yaml, as it will then rely on the yaml-exclusive !tag feature. Alternatively, just switch to serde-json instead and give up on user-readable configs? Or support both via file extension and/or other option?

EDIT: singleton_map_recursive is what you actually want, to work around Vec issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant