Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: mets-reader-writer does not use Python 3 (metsrw) #811

Closed
sallain opened this issue Jul 19, 2019 · 2 comments
Closed

Problem: mets-reader-writer does not use Python 3 (metsrw) #811

sallain opened this issue Jul 19, 2019 · 2 comments

Comments

@sallain
Copy link
Member

sallain commented Jul 19, 2019

Please describe the problem you'd like to be solved.
mets-reader-writer needs to use Python 3 as per the Python 3 ADR.

Describe the solution you'd like to see implemented.
Refactor mets-reader-writer to use Python 3.

Additional context
Some Python 3 compatibility work has already been done on mets-reader-writer. This component should be checked to ensure that all code has been refactored.


For Artefactual use:
Please make sure these steps are taken before moving this issue from Review to Done:

  • All PRs related to this issue are properly linked 👍
  • All PRs related to this issue have been merged 👍
  • Test plan for this issue has been implemented and passed 👍
  • Documentation regarding this issue has been written and it has been added to the release notes, if needed 👍
@sallain
Copy link
Member Author

sallain commented Jul 19, 2019

Related: #580

@sallain sallain added this to the 2.0.0 milestone Jul 25, 2019
@sallain sallain removed this from the 2.0.0 milestone Nov 26, 2019
@ross-spencer ross-spencer changed the title Problem: mets-reader-writer does not use Python 3 Problem: mets-reader-writer does not use Python 3 (metsrw) Jan 16, 2020
@jraddaoui
Copy link

The mets-reader-writer CI already run the tests in 2.7 and 3.5 to 3.7 and the PR above adds 3.8 to that list. The coverage seems to be pretty good:

Name                                  Stmts   Miss Branch BrPart  Cover
-----------------------------------------------------------------------
metsrw/__init__.py                       15      0      0      0   100%
metsrw/di.py                             80      6     28      4    89%
metsrw/exceptions.py                      4      0      0      0   100%
metsrw/fsentry.py                       233     16    101      7    92%
metsrw/metadata.py                      291      6    112      8    96%
metsrw/mets.py                          325     12    137     12    94%
metsrw/plugins/__init__.py                0      0      0      0   100%
metsrw/plugins/premisrw/__init__.py       8      0      0      0   100%
metsrw/plugins/premisrw/premis.py       405     21    177     12    94%
metsrw/plugins/premisrw/utils.py         43      0      6      0   100%
metsrw/utils.py                          17      0      4      0   100%
metsrw/validate.py                       67      7     16      5    86%
-----------------------------------------------------------------------
TOTAL                                  1488     68    581     48    94%

@sromkey sromkey added this to the 1.13.0 milestone Mar 5, 2021
@sromkey sromkey added the Status: refining The issue needs additional details to ensure that requirements are clear. label Mar 5, 2021
@sevein sevein added Status: ready The issue is sufficiently described/scoped to be picked up by a developer. Status: review The issue's code has been merged and is ready for testing/review. and removed Status: refining The issue needs additional details to ensure that requirements are clear. Status: ready The issue is sufficiently described/scoped to be picked up by a developer. labels Mar 5, 2021
@sevein sevein closed this as completed Jun 25, 2021
@sevein sevein removed the Status: review The issue's code has been merged and is ready for testing/review. label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants