Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String widgets (text and rich-text) won't allow edits to be saved once the value has become null #11658

Open
SDScandrettKint opened this issue Nov 27, 2024 · 4 comments
Assignees

Comments

@SDScandrettKint
Copy link
Member

SDScandrettKint commented Nov 27, 2024

Tested in 7.4.x, 7.5.x & 7.6.x

The string widgets (text and rich-text) won't allow edits to be saved once the value has become null. Video demonstration is attached below. It looks like once the node value has been converted to null, the dirty state isn't prompted and the inputs aren't retained.

Steps to reproduce:

  1. In a model with a string node, enter string data and save the node.
  2. Remove the string and save again.
  3. Try add string data back - this will not prompt a dirty state and the data can't be added.

Refreshing the page gets it to work again.

Video demonstration for both text and rich text widgets:

String_issue_7.6.mp4

This also happens when a node (e.g. concept, date etc) is saved in a card that consists of lots of nodes (string included) where the string node is left blank.

string_edits.mp4
@chiatt chiatt added this to pipeline Nov 27, 2024
@SDScandrettKint
Copy link
Member Author

Unsure if related, but once a save has been made to another node (e.g. concept) and text is entered into the rich text or regular text widgets the values disappear once moving away and back to the card, but the data is persisted in the node preview on the left side

string_persisting_issue.mp4

@SDScandrettKint SDScandrettKint changed the title Empty string datatype/widget won't accept edits once a save has already been made Empty string datatype/widget won't accept edits once a save has already been made, or persist the new value Nov 28, 2024
@SDScandrettKint

This comment was marked as resolved.

@SDScandrettKint SDScandrettKint changed the title Empty string datatype/widget won't accept edits once a save has already been made, or persist the new value Widgets won't accept edits once a save has already been made, or persist the new values Nov 28, 2024
@SDScandrettKint SDScandrettKint changed the title Widgets won't accept edits once a save has already been made, or persist the new values String (and rich-text) widgets won't accept edits once a save has already been made, or persist the new values Dec 1, 2024
@SDScandrettKint SDScandrettKint changed the title String (and rich-text) widgets won't accept edits once a save has already been made, or persist the new values String widgets (text and rich-text) won't allow edits to be saved once the value has become null Dec 20, 2024
@SDScandrettKint SDScandrettKint self-assigned this Dec 20, 2024
@SDScandrettKint
Copy link
Member Author

Note: I've just tested this in 7.4 and the issue is still present.

@SDScandrettKint
Copy link
Member Author

This issue feels connected to this issue #10796.
Both datatypes (string and URL) have a JSON structure, and setting them to null is causing the same UI response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant