Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't search for numbers in the search bar #11619

Closed
CWDamm-Kint opened this issue Nov 12, 2024 · 4 comments · Fixed by #11623
Closed

Can't search for numbers in the search bar #11619

CWDamm-Kint opened this issue Nov 12, 2024 · 4 comments · Fixed by #11623
Assignees

Comments

@CWDamm-Kint
Copy link
Contributor

When searching for a number, the search bar appears to treat it as a string. When you try to click on the search bar to cancel this behaviour, you run into a related issue, where search text disappears upon clicking the search bar: #11618

Searching.for.a.number.mp4
@chiatt chiatt added this to pipeline Nov 12, 2024
@CWDamm-Kint
Copy link
Contributor Author

Tested in 7.6 and 8.0.x

@chiatt
Copy link
Member

chiatt commented Nov 12, 2024

I think the issue here is that the search bar performs a 'term' search, so it only searches for string terms. I think other datatypes such as dates and edtf won't work here either. I can see how people might expect numbers to be treated as terms, though. We could probably index them that way. @apeters might have more insight on this.

@chiatt
Copy link
Member

chiatt commented Nov 12, 2024

It looks like all we would have to do is add a get_search_terms method to the number datatype.

@apeters
Copy link
Member

apeters commented Nov 12, 2024

It would be easy enough as @chiatt mentioned all you need to do is add that method to the datatype.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants