Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ArchesFileReader.import_business_data() for readability #11401

Open
jacobtylerwalls opened this issue Aug 27, 2024 · 2 comments
Open

Comments

@jacobtylerwalls
Copy link
Member

At its maximum, there are 21 levels of indentation in this function. We should refactor to avoid so much indentation.

(The github preview below doesn't do it justice, so click through):

if (
child_tile_cardinality
== "1"
):
populated_child_nodegroups.append(
prototype_tile.nodegroup_id
)

@chiatt chiatt added this to pipeline Aug 27, 2024
@caineblood

This comment was marked as resolved.

@archesproject archesproject deleted a comment Aug 27, 2024
@archesproject archesproject deleted a comment Aug 27, 2024
@chiatt
Copy link
Member

chiatt commented Nov 18, 2024

It would be nice to transition away from this and the csvfile importer and use the bulk data manager for these formats instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants