From 1d5ac23683fb54162018c0ea371af8881622593f Mon Sep 17 00:00:00 2001
From: Jacob Walls <jwalls@fargeo.com>
Date: Fri, 17 May 2024 11:22:12 -0400
Subject: [PATCH] Add front-end routing #10598

---
 .../plugins/controlled-list-manager.js        | 13 +++
 .../ControlledListEditor.vue                  | 18 ++++-
 .../ControlledListManager/constants.ts        |  6 ++
 .../tree/AddDeleteControls.vue                |  2 -
 .../ControlledListManager/tree/ListTree.vue   |  6 +-
 .../tree/ListTreeControls.vue                 | 80 ++++++++++++++++++-
 .../ControlledListManager/tree/MoveRow.vue    | 14 ++--
 .../ControlledListManager/tree/TreeRow.vue    |  4 +-
 .../components/ControlledListManager/utils.ts | 20 +++--
 .../app/src/plugins/ControlledListManager.vue |  3 +
 arches/urls.py                                |  4 +-
 11 files changed, 146 insertions(+), 24 deletions(-)

diff --git a/arches/app/media/js/views/components/plugins/controlled-list-manager.js b/arches/app/media/js/views/components/plugins/controlled-list-manager.js
index 6e73a28a5b1..545c932875e 100644
--- a/arches/app/media/js/views/components/plugins/controlled-list-manager.js
+++ b/arches/app/media/js/views/components/plugins/controlled-list-manager.js
@@ -3,10 +3,23 @@ import ControlledListManager from '@/plugins/ControlledListManager.vue';
 import createVueApp from 'utils/create-vue-application';
 import ControlledListManagerTemplate from 'templates/views/components/plugins/controlled-list-manager.htm';
 
+import { createRouter, createWebHistory } from 'vue-router';
+
+const routes = [
+  { path: '/plugins/controlled-list-manager', name: 'splash', component: ControlledListManager },
+  { path: '/plugins/controlled-list-manager/list/:id', name: 'list', component: ControlledListManager },
+  { path: '/plugins/controlled-list-manager/item/:id', name: 'item', component: ControlledListManager },
+];
+
+const router = createRouter({
+  history: createWebHistory(),
+  routes,
+});
 
 ko.components.register('controlled-list-manager', {
     viewModel: function() {
         createVueApp(ControlledListManager).then((vueApp) => {
+            vueApp.use(router);
             vueApp.mount('#controlled-list-manager-mounting-point');
         })
     },
diff --git a/arches/app/src/components/ControlledListManager/ControlledListEditor.vue b/arches/app/src/components/ControlledListManager/ControlledListEditor.vue
index 8bce1535cef..7bc01525ffe 100644
--- a/arches/app/src/components/ControlledListManager/ControlledListEditor.vue
+++ b/arches/app/src/components/ControlledListManager/ControlledListEditor.vue
@@ -1,6 +1,7 @@
 <script setup lang="ts">
 import arches from "arches";
 import { computed, provide, ref } from "vue";
+import { useRouter } from "vue-router";
 
 import ProgressSpinner from "primevue/progressspinner";
 import Splitter from "primevue/splitter";
@@ -9,6 +10,7 @@ import SplitterPanel from "primevue/splitterpanel";
 import { LIGHT_GRAY } from "@/theme.ts";
 import {
     displayedRowKey,
+    routes,
     selectedLanguageKey,
 } from "@/components/ControlledListManager/constants.ts";
 import { dataIsList } from "@/components/ControlledListManager/utils.ts";
@@ -19,14 +21,24 @@ import ListHeader from "@/components/ControlledListManager/misc/ListHeader.vue";
 import ListTree from "@/components/ControlledListManager/tree/ListTree.vue";
 
 import type { Ref } from "vue";
-import type { Selectable } from "@/types/ControlledListManager";
+import type {
+    ControlledListItem,
+    Selectable,
+} from "@/types/ControlledListManager";
 import type { Language } from "@/types/arches";
 
-const splash = "splash";
+const router = useRouter();
 
 const displayedRow: Ref<Selectable | null> = ref(null);
 function setDisplayedRow(val: Selectable | null) {
     displayedRow.value = val;
+    if (val === null) {
+        router.push({ name: routes.splash });
+    } else if ((val as ControlledListItem).controlled_list_id) {
+        router.push({ name: routes.item, params: { id: val.id } });
+    } else {
+        router.push({ name: routes.list, params: { id: val.id } });
+    }
 }
 provide(displayedRowKey, { displayedRow, setDisplayedRow });
 
@@ -85,7 +97,7 @@ const panel = computed(() => {
             >
                 <component
                     :is="panel"
-                    :key="displayedRow?.id ?? splash"
+                    :key="displayedRow?.id ?? routes.splash"
                 />
             </SplitterPanel>
         </Splitter>
diff --git a/arches/app/src/components/ControlledListManager/constants.ts b/arches/app/src/components/ControlledListManager/constants.ts
index 9a25dd8f3a6..cbeb35baa1a 100644
--- a/arches/app/src/components/ControlledListManager/constants.ts
+++ b/arches/app/src/components/ControlledListManager/constants.ts
@@ -18,6 +18,12 @@ export const ERROR = "error";
 export const DANGER = "danger";
 export const DEFAULT_ERROR_TOAST_LIFE = 8000;
 
+export const routes = {
+    splash: "splash",
+    list: "list",
+    item: "item",
+};
+
 // Django model choices
 export const METADATA_CHOICES = {
     title: "title",
diff --git a/arches/app/src/components/ControlledListManager/tree/AddDeleteControls.vue b/arches/app/src/components/ControlledListManager/tree/AddDeleteControls.vue
index 10e8af10150..d36c963279a 100644
--- a/arches/app/src/components/ControlledListManager/tree/AddDeleteControls.vue
+++ b/arches/app/src/components/ControlledListManager/tree/AddDeleteControls.vue
@@ -5,7 +5,6 @@ import { useGettext } from "vue3-gettext";
 import { useConfirm } from "primevue/useconfirm";
 import { useToast } from "primevue/usetoast";
 import Button from "primevue/button";
-import ConfirmDialog from "primevue/confirmdialog";
 import SplitButton from "primevue/splitbutton";
 
 import { BUTTON_GREEN } from "@/theme.ts";
@@ -203,7 +202,6 @@ await fetchListsAndPopulateTree();
         :pt="{ root: { style: { background: BUTTON_GREEN } } }"
         @click="createList"
     />
-    <ConfirmDialog :draggable="false" />
     <SplitButton
         class="list-button"
         :label="$gettext('Delete')"
diff --git a/arches/app/src/components/ControlledListManager/tree/ListTree.vue b/arches/app/src/components/ControlledListManager/tree/ListTree.vue
index 4af7586ee0b..dd96c76871f 100644
--- a/arches/app/src/components/ControlledListManager/tree/ListTree.vue
+++ b/arches/app/src/components/ControlledListManager/tree/ListTree.vue
@@ -72,6 +72,10 @@ const collapseNodesRecursive = (node: TreeNode) => {
 };
 
 const updateSelectedAndExpanded = (node: TreeNode) => {
+    if (isMultiSelecting.value || movingItem.value.key) {
+        return;
+    }
+
     let priorListId;
     if (displayedRow.value) {
         priorListId =
@@ -190,7 +194,7 @@ const filterCallbackWrapped = computed(() => {
 <template>
     <ListTreeControls
         :key="refetcher"
-        v-model="tree"
+        v-model:tree="tree"
         v-model:rerender-tree="rerenderTree"
         v-model:expanded-keys="expandedKeys"
         v-model:selected-keys="selectedKeys"
diff --git a/arches/app/src/components/ControlledListManager/tree/ListTreeControls.vue b/arches/app/src/components/ControlledListManager/tree/ListTreeControls.vue
index 2357140917f..d4c22784d18 100644
--- a/arches/app/src/components/ControlledListManager/tree/ListTreeControls.vue
+++ b/arches/app/src/components/ControlledListManager/tree/ListTreeControls.vue
@@ -1,13 +1,26 @@
 <script setup lang="ts">
+import { inject, watch } from "vue";
+import { useRoute } from "vue-router";
+
+import {
+    displayedRowKey,
+    routes,
+} from "@/components/ControlledListManager/constants.ts";
+import { findNodeInTree } from "@/components/ControlledListManager/utils.ts";
 import ActionBanner from "@/components/ControlledListManager/tree/ActionBanner.vue";
 import AddDeleteControls from "@/components/ControlledListManager/tree/AddDeleteControls.vue";
 import PresentationControls from "@/components/ControlledListManager/tree/PresentationControls.vue";
 
 import type { TreeExpandedKeys, TreeSelectionKeys } from "primevue/tree/Tree";
 import type { TreeNode } from "primevue/treenode";
-import type { NewControlledList } from "@/types/ControlledListManager";
+import type {
+    DisplayedListItemRefAndSetter,
+    NewControlledList,
+} from "@/types/ControlledListManager";
 
-const controlledListItemsTree = defineModel<TreeNode[]>({ required: true });
+const controlledListItemsTree = defineModel<TreeNode[]>("tree", {
+    required: true,
+});
 const rerenderTree = defineModel<number>("rerenderTree", { required: true });
 const expandedKeys = defineModel<TreeExpandedKeys>("expandedKeys", {
     required: true,
@@ -24,6 +37,69 @@ const newListFormValue = defineModel<string>("newListFormValue", {
     required: true,
 });
 
+const { setDisplayedRow } = inject(
+    displayedRowKey,
+) as DisplayedListItemRefAndSetter;
+
+const route = useRoute();
+
+// React to route changes.
+// Add list tree as dependency so it runs on initial fetch.
+watch(
+    [
+        () => {
+            return { ...route };
+        },
+        controlledListItemsTree,
+    ],
+    ([newRoute]) => {
+        switch (newRoute.name) {
+            case routes.splash:
+                setDisplayedRow(null);
+                break;
+            case routes.list: {
+                if (!controlledListItemsTree.value.length) {
+                    return;
+                }
+                const list = controlledListItemsTree.value.find(
+                    (node) => node.data.id === newRoute.params.id,
+                );
+                if (list) {
+                    setDisplayedRow(list.data);
+                    expandedKeys.value = { [list.data.id]: true };
+                    selectedKeys.value = { [list.data.id]: true };
+                } else {
+                    setDisplayedRow(null);
+                }
+                break;
+            }
+            case routes.item: {
+                if (!controlledListItemsTree.value.length) {
+                    return;
+                }
+                const { found, path } = findNodeInTree(
+                    controlledListItemsTree.value,
+                    newRoute.params.id,
+                );
+                if (found) {
+                    setDisplayedRow(found.data);
+                    const itemsToExpandIds = path.map(
+                        (itemInPath: TreeNode) => itemInPath.key,
+                    );
+                    expandedKeys.value = Object.fromEntries(
+                        [
+                            found.data.controlled_list_id,
+                            ...itemsToExpandIds,
+                        ].map((x) => [x, true]),
+                    );
+                    selectedKeys.value = { [found.data.id]: true };
+                }
+                break;
+            }
+        }
+    },
+);
+
 const expandAll = () => {
     for (const node of controlledListItemsTree.value) {
         expandNode(node);
diff --git a/arches/app/src/components/ControlledListManager/tree/MoveRow.vue b/arches/app/src/components/ControlledListManager/tree/MoveRow.vue
index a3f000ac23b..b10048057fb 100644
--- a/arches/app/src/components/ControlledListManager/tree/MoveRow.vue
+++ b/arches/app/src/components/ControlledListManager/tree/MoveRow.vue
@@ -63,8 +63,8 @@ const newLabelCounter = ref(1);
 
 const isFirstItem = (item: ControlledListItem) => {
     const siblings: TreeNode[] = item.parent_id
-        ? findNodeInTree(tree.value, item.parent_id).data.children
-        : findNodeInTree(tree.value, item.controlled_list_id).data.items;
+        ? findNodeInTree(tree.value, item.parent_id).found.data.children
+        : findNodeInTree(tree.value, item.controlled_list_id).found.data.items;
     if (!siblings) {
         throw new Error();
     }
@@ -73,8 +73,8 @@ const isFirstItem = (item: ControlledListItem) => {
 
 const isLastItem = (item: ControlledListItem) => {
     const siblings: TreeNode[] = item.parent_id
-        ? findNodeInTree(tree.value, item.parent_id).data.children
-        : findNodeInTree(tree.value, item.controlled_list_id).data.items;
+        ? findNodeInTree(tree.value, item.parent_id).found.data.children
+        : findNodeInTree(tree.value, item.controlled_list_id).found.data.items;
     if (!siblings) {
         throw new Error();
     }
@@ -85,7 +85,7 @@ const setMovingItem = (node: TreeNode) => {
     movingItem.value = findNodeInTree(
         [itemAsNode(displayedRow.value, selectedLanguage.value)],
         node.key,
-    );
+    ).found;
 };
 
 const addItem = (parent: TreeNode) => {
@@ -128,11 +128,11 @@ const reorder = async (item: ControlledListItem, up: boolean) => {
     const list: ControlledList = findNodeInTree(
         tree.value,
         item.controlled_list_id,
-    ).data;
+    ).found.data;
 
     let siblings: ControlledListItem[];
     if (item.parent_id) {
-        siblings = findNodeInTree(tree.value, item.parent_id).children.map(
+        siblings = findNodeInTree(tree.value, item.parent_id).found.children.map(
             (child: TreeNode) => child.data,
         );
     } else {
diff --git a/arches/app/src/components/ControlledListManager/tree/TreeRow.vue b/arches/app/src/components/ControlledListManager/tree/TreeRow.vue
index a9771104694..64302f87d4d 100644
--- a/arches/app/src/components/ControlledListManager/tree/TreeRow.vue
+++ b/arches/app/src/components/ControlledListManager/tree/TreeRow.vue
@@ -130,7 +130,7 @@ const setParent = async (parentNode: TreeNode) => {
         siblings.push(item);
     } else {
         item.parent_id = parentNode.key;
-        list = findNodeInTree(tree.value, item.controlled_list_id).data;
+        list = findNodeInTree(tree.value, item.controlled_list_id).found.data;
         siblings = parentNode.data.children;
         siblings.push(item);
     }
@@ -198,7 +198,7 @@ const acceptNewItemShortcutEntry = async () => {
     const parent = findNodeInTree(
         tree.value,
         newItem.parent_id ?? newItem.controlled_list_id,
-    );
+    ).found;
     parent.children = [
         ...parent.children.filter(
             (child: TreeNode) => typeof child.key === "string",
diff --git a/arches/app/src/components/ControlledListManager/utils.ts b/arches/app/src/components/ControlledListManager/utils.ts
index 181e04ff74f..f667f096aff 100644
--- a/arches/app/src/components/ControlledListManager/utils.ts
+++ b/arches/app/src/components/ControlledListManager/utils.ts
@@ -37,22 +37,32 @@ export const languageNameFromCode = (code: string) => {
     return arches.languages.find((lang: Language) => lang.code === code).name;
 };
 
-export const findNodeInTree = (tree: TreeNode[], itemId: string) => {
+export const findNodeInTree = (
+    tree: TreeNode[],
+    itemId: string,
+): {
+    found: TreeNode | undefined;
+    path: TreeNode[];
+} => {
+    const path: TreeNode[] = [];
+
     function recurse(items: TreeNode[]): TreeNode | undefined {
         for (const item of items) {
             if (item.data.id === itemId) {
                 return item;
             }
             for (const child of item.items ?? item.children) {
-                const maybeFound = recurse([child]);
-                if (maybeFound) {
-                    return maybeFound;
+                const found = recurse([child]);
+                if (found) {
+                    path.push(item);
+                    return found;
                 }
             }
         }
     }
 
-    return recurse(tree);
+    const found = recurse(tree);
+    return { found, path };
 };
 
 export const itemAsNode = (
diff --git a/arches/app/src/plugins/ControlledListManager.vue b/arches/app/src/plugins/ControlledListManager.vue
index 709b1b624e1..635456f89b1 100644
--- a/arches/app/src/plugins/ControlledListManager.vue
+++ b/arches/app/src/plugins/ControlledListManager.vue
@@ -1,4 +1,5 @@
 <script setup lang="ts">
+import ConfirmDialog from "primevue/confirmdialog";
 import Toast from "primevue/toast";
 
 import ControlledListEditor from "@/components/ControlledListManager/ControlledListEditor.vue";
@@ -11,7 +12,9 @@ import ControlledListEditor from "@/components/ControlledListManager/ControlledL
             <ControlledListEditor />
         </div>
     </div>
+    <ConfirmDialog :draggable="false" />
     <Toast />
+    <RouterView />
 </template>
 
 <!-- Not scoped: workaround for lack of font-family in <body> -->
diff --git a/arches/urls.py b/arches/urls.py
index 8ebecad3d1e..35e0fc31138 100644
--- a/arches/urls.py
+++ b/arches/urls.py
@@ -644,9 +644,9 @@
         name="concepts",
     ),
     re_path(
-        r"^plugins/(?P<pluginid>%s)$" % uuid_regex, PluginView.as_view(), name="plugins"
+        r"^plugins/(?P<pluginid>%s)" % uuid_regex, PluginView.as_view(), name="plugins"
     ),
-    re_path(r"^plugins/(?P<slug>[-\w]+)$", PluginView.as_view(), name="plugins"),
+    re_path(r"^plugins/(?P<slug>[-\w]+)", PluginView.as_view(), name="plugins"),
     re_path(
         r"^workflow_history/(?P<workflowid>%s|())$" % uuid_regex,
         WorkflowHistoryView.as_view(),