Changes to allow for a single form per tile #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongundel
force-pushed
the
adg/154-single-tile-forms
branch
from
0d8dc76 to
0175346
Compare
chrabyrd
reviewed
Dec 30, 2024
| @@ -26,32 +26,19 @@ defineProps<{ | |||
| mode?: DataComponentMode; | |||
| }>(); | |||
|
|
|||
| defineEmits([OPEN_EDITOR]); | |||
| const emit = defineEmits([OPEN_EDITOR, "updated"]); | |||
There was a problem hiding this comment.
nit: emits to match the rest of the app
| ), | ||
| }); | ||
| } | ||
| await updateSchemeNamespace( |
| schemeComponents.find((component) => { | ||
| return component.id === newValue.activeTab; | ||
| }) || schemeComponents[0]; | ||
| console.log(currentEditor.value); |
| currentEditor.value = | ||
| schemeComponents.find((component) => { | ||
| return component.id === newValue.activeTab; | ||
| }) || schemeComponents[0]; |
There was a problem hiding this comment.
could this fallback end up being confusing for the user?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for a single editor per tile, removes tabbed interface.