Adds scheme names/labels section #153
Conversation
|
This will need to merge into main before/at the same time as JC's form editor ticket. |
arches_lingo/src/arches_lingo/components/scheme/report/SchemeStandard.vue
Outdated
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/scheme/report/SchemeStandard.vue
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/scheme/report/SchemeSection.vue
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/generic/LabelViewer.vue
Outdated
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/generic/LabelViewer.vue
Outdated
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/generic/LabelViewer.vue
Outdated
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/generic/LabelViewer.vue
Outdated
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/generic/LabelViewer.vue
Outdated
Show resolved
Hide resolved
| /> | ||
| <Column | ||
| field="appellative_status_ascribed_name_content" | ||
| header="Label" |
arches_lingo/src/arches_lingo/components/generic/ResourceInstanceRelationships.vue
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/scheme/report/SchemeStandard.vue
Outdated
Show resolved
Hide resolved
|
There is a second, related item to genericize the label viewer. I separated it from this PR to get commentary on patterns therein. See #161 - set to merge into this PR. |
| emits("deleteLabel", tileId); | ||
| }, | ||
| rejectProps: { | ||
| label: "Cancel", |
There was a problem hiding this comment.
done in label viewer genericizing.
| import type { AppellativeStatus } from "@/arches_lingo/types"; | ||
|
|
||
| const { $gettext } = useGettext(); | ||
| const expandedRows = ref([]); |
There was a problem hiding this comment.
nit: declare generic refs below props/emits
| }, | ||
| acceptProps: { | ||
| label: "Delete", | ||
| severity: "danger", |
There was a problem hiding this comment.
the severity labels exist in constants.ts
There was a problem hiding this comment.
done in label viewer genericizing.
| ? error.message | ||
| : $gettext("Could not save the scheme standard"), | ||
| }); | ||
| } | ||
|
|
||
| getSectionValue(); | ||
| } | ||
|
|
||
| async function getSectionValue() { |
There was a problem hiding this comment.
looks like this could be abstracted to 2 functions to improve readability
* adds notes section * fix naming nit * wrap gettext in spans * pr feedback * pr feedback
aarongundel
force-pushed
the
adg/146-scheme-names
branch
from
eb4d590 to
21057da
Compare
| const options = await getCachedOptions(); | ||
|
|
||
| if (options) { | ||
| await setSchemeInstance(options); |
There was a problem hiding this comment.
nit: don't need to await this
| ResourceInstanceReference[] | undefined | ||
| > { | ||
| try { | ||
| const options = !textualWorkOptions.value |
There was a problem hiding this comment.
nit: invert this
const options = textualWorkOptions.value || await getOptions();
| getSectionValue(); | ||
| emit(UPDATED); |
There was a problem hiding this comment.
nit: would move these inside the try as these will still run even if that errors
| ), | ||
| }); | ||
| } | ||
| emit(UPDATED); |
There was a problem hiding this comment.
same with this, it will run regardless of success
arches_lingo/src/arches_lingo/components/generic/LabelViewer.vue
Outdated
Show resolved
Hide resolved
| }, | ||
| acceptProps: { | ||
| label: "Delete", | ||
| severity: "danger", |
| emits("deleteLabel", tileId); | ||
| }, | ||
| rejectProps: { | ||
| label: "Cancel", |
|
🏓 |
* Changes to allow for a single form per tile * move section types to prep for conflict * PR feedback * pr feedback * purge tab * purge more tabs
aarongundel
force-pushed
the
adg/146-scheme-names
branch
from
3f68847 to
fa5dc08
Compare
Adds scheme names/labels section