Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdfs do not render in file interp. step until side panel is closed or mousing out of the window #1396

Open
chiatt opened this issue Oct 27, 2023 · 6 comments

Comments

@chiatt
Copy link
Member

chiatt commented Oct 27, 2023

The fix for this might need to be applied in core rather than afs.
https://github.com/archesproject/arches-for-science/assets/1877663/cbe55a76-0e50-4edb-9ad5-ec2fc1a50ebc

@chiatt chiatt moved this to 🔖 Ready in afs-pipeline Oct 27, 2023
@jacobtylerwalls jacobtylerwalls moved this from 🔖 Ready to 🏗 In progress in afs-pipeline Nov 7, 2023
@jacobtylerwalls
Copy link
Member

Works if the window is resized.

@jacobtylerwalls
Copy link
Member

Also works if the user mouses out of the window. Also works unconditionally on Safari. I think this is a Chrome bug, potentially; either that or a bug with select2's filtering mousemove events.

Quick hacks I tried:

  • adding a setTimeout that adds dummy divs to the DOM
  • ... same, but selecting the select2 element and programmatically clicking it (couldn't)

If you have the dev overlay for errors still on, you can "fix" this by just throwing a console error from anywhere in the code after the select2 widget loads (e.g. with a ko.when()) and causing an error overlay. But that's just a symptom of the problem.

Suggesting to put this on hold for now. We could retest after moving to selectwoo.

@jacobtylerwalls jacobtylerwalls moved this from 🏗 In progress to 📋 On hold in afs-pipeline Nov 7, 2023
@jacobtylerwalls jacobtylerwalls removed their assignment Nov 7, 2023
@chiatt
Copy link
Member Author

chiatt commented Dec 21, 2023

Maybe something a bit ugly like $(window).trigger("resize"); would do the trick? Seems like the addition of divs would have had a similar effect, though.

@jacobtylerwalls
Copy link
Member

@chiatt did you retest after selectwoo replaced select2? I can if you haven't yet.

@chiatt chiatt removed the status in afs-pipeline Dec 21, 2023
@chiatt chiatt moved this to 🔖 Ready in afs-pipeline Dec 21, 2023
@chiatt
Copy link
Member Author

chiatt commented Dec 21, 2023

Thanks @jacobtylerwalls, I haven't yet

@jacobtylerwalls
Copy link
Member

Unfortunately still seeing this with selectwoo

@jacobtylerwalls jacobtylerwalls changed the title pdfs do not render in file interp. step until side panel is closed pdfs do not render in file interp. step until side panel is closed or mousing out of the window Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready
Development

No branches or pull requests

2 participants