Don't reach into build folder of jest-resolve

[SimenB]

Jest is currently renaming files: jestjs/jest#4969

The default resolver should probably be exported from main

[arcanis]

I think a better option might be for jest-resolve to default to either:

• pass the default resolver as an option to the custom resolver, and/or
• use the default resolver when the custom resolver's module.exports is not a function

In both of these cases, jest-pnp-resolver could then disable itself without having to keep a dependency to jest-resolve. How does that sound?

[SimenB]

The first one sounds good to me, feels more explicit and allows people to implement a resolver that can fall back to default behavior if they cannot find their module for whatever reason.

[SimenB]

Out in 24.1.0

[arcanis]

@SimenB fyi I was thinking I could keep the ugly thing until most of the ecosystem switches on Jest 24 (so probably until Jest 25, I'd say). Does that sound ok?

[SimenB]

Sure! However, you can check if you get it passed in now, and only do your require if not?

[arcanis]

Hmm that might work yeah - it adds a slight indirection but it shouldn't be a big deal in most cases 👍

[terwort]

Hey guys, I'm trying to update to jest 24, and I'm getting the error about how it can't find the old path (default_resolver). I saw in index.js you implemented the ugly thing, but in your latest release, 1.0.2, this code isn't there. Any chance the fix will get released soon?

[terwort]

Ahh.. just noticed you referenced a PR that will close this problem. Any idea on release time?

[arcanis]

@terwort I've just merged and released the change as 1.1.0 - can you confirm the fix? Seems to work for me.

[terwort]

@arcanis I can confirm it is fixed! Thank you very much for your fast delivery 😄