Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cluster] Clean dead server #711

Closed
orgrimarr opened this issue Dec 22, 2020 · 1 comment
Closed

[Cluster] Clean dead server #711

orgrimarr opened this issue Dec 22, 2020 · 1 comment
Labels
Feature Request Request for new functionality to be added to the driver. semver-minor This issue does not require any backwards-incompatible changes to address.

Comments

@orgrimarr
Copy link

Environment

  • ArangoJS: 7.2.0
  • ArangoDB 3.7.5 Cluster
    • Tested on docker
    • Tested on windows

Description

Arangojs connected to a cluster in ROUND_ROBIN mode does not clean dead servers from the host list.

Arangojs provide a method : acquireHostList but this function append new coordinator to the host list using addToHostList function.

I suggest to change the acquireHostList function to replace the host list with the list of available server from /_api/cluster/endpoints

@pluma
Copy link
Contributor

pluma commented Jan 13, 2021

This would be a breaking change, but I think a compromise would be to add an alternative method (say, updateHostList) that replaces rather than updates the known hosts.

One issue with this is that right now the hosts list is an array and thus hosts are identified by their index, which will cause problems if e.g. a cursor is created from a host which is then removed from the list. This probably requires some internal changes.

@pluma pluma added Feature Request Request for new functionality to be added to the driver. semver-minor This issue does not require any backwards-incompatible changes to address. labels Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Request for new functionality to be added to the driver. semver-minor This issue does not require any backwards-incompatible changes to address.
Projects
None yet
Development

No branches or pull requests

2 participants