Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ignoreRevs on Collection.delete() calls #708

Closed
robross0606 opened this issue Dec 17, 2020 · 2 comments
Closed

Support ignoreRevs on Collection.delete() calls #708

robross0606 opened this issue Dec 17, 2020 · 2 comments
Labels
Bug A code defect that needs to be fixed. duplicate This issue is already addressed by another issue.

Comments

@robross0606
Copy link

robross0606 commented Dec 17, 2020

The HTTP API for ArangoDB supports revision checking on document removal via the If-Match header:

https://www.arangodb.com/docs/stable/http/document-working-with-documents.html#removes-a-document

However, the ArangoJS API doesn't expose this option. It should be exposed similar to how Collection.update() calls used to work prior to 7.x. Or, at least, how they're supposed to work (#707).

@pluma
Copy link
Contributor

pluma commented Jan 13, 2021

I'm closing this as a duplicate of #707 as that issue provides more additional information and the solution seems to be to re-implement the if-match header from v6.

@pluma pluma closed this as completed Jan 13, 2021
@pluma pluma added Bug A code defect that needs to be fixed. duplicate This issue is already addressed by another issue. labels Jan 13, 2021
@robross0606
Copy link
Author

robross0606 commented Jan 26, 2021

I'm not sure this should have been closed. I don't know if Collection.delete() on ArangoJS ever supported revision checks via If-Match. #707 is a bug ticket on Collection.update(). I had submitted this as a feature request on Collection.delete(). Just want to make sure we're tracking the distinction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A code defect that needs to be fixed. duplicate This issue is already addressed by another issue.
Projects
None yet
Development

No branches or pull requests

2 participants