fix(transCore): when no suffix don't match spaces #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@allcontributors please add @slevy85 for code |
|
I've put up a pull request to add @slevy85! 🎉 |
|
@slevy85 I prereleased under 1.0.5-canary.2 if you want to start using it |
aralroca
added a commit
that referenced
this pull request
Mar 22, 2021
* replace quotes only for the special $' pattern specific to .replace() (#529) * replace quotes only for the special $' pattern specific to .replace() instead of replacing quoutes everywhere * use .replace() callback to avoid parsing special string patterns * write tests to verify that templateWithHoc and templateWithLoader correctly replaces special string cases. Update snapshots * Update package version * fix(transCore): when no suffix don't match spaces (#534) * Update package version * _one works (#541) * Update package version * Update README.md (#552) * Update package version * Update dependencies (#554) * Update dependencies * Update example deps Co-authored-by: AndrewB <[email protected]> Co-authored-by: slevy85 <[email protected]> Co-authored-by: Justin <[email protected]>
aralroca
added a commit
that referenced
this pull request
Apr 17, 2021
* replace quotes only for the special $' pattern specific to .replace() (#529) * replace quotes only for the special $' pattern specific to .replace() instead of replacing quoutes everywhere * use .replace() callback to avoid parsing special string patterns * write tests to verify that templateWithHoc and templateWithLoader correctly replaces special string cases. Update snapshots * Update package version * fix(transCore): when no suffix don't match spaces (#534) * Update package version * _one works (#541) * Update package version * Update README.md (#552) * Update package version * Update dependencies (#554) * Update dependencies * Update example deps * Update Trans text after change lang (#566) * Ignore api.(ts|js...) file (#567) * Add useMemo to useTranslation (#574) * Update deps (#582) * Update version of package.json Co-authored-by: AndrewB <[email protected]> Co-authored-by: slevy85 <[email protected]> Co-authored-by: Justin <[email protected]>
aralroca
added a commit
that referenced
this pull request
May 21, 2021
* replace quotes only for the special $' pattern specific to .replace() (#529) * replace quotes only for the special $' pattern specific to .replace() instead of replacing quoutes everywhere * use .replace() callback to avoid parsing special string patterns * write tests to verify that templateWithHoc and templateWithLoader correctly replaces special string cases. Update snapshots * Update package version * fix(transCore): when no suffix don't match spaces (#534) * Update package version * _one works (#541) * Update package version * Update README.md (#552) * Update package version * Update dependencies (#554) * Update dependencies * Update example deps * Update Trans text after change lang (#566) * Ignore api.(ts|js...) file (#567) * Add useMemo to useTranslation (#574) * Update deps (#582) * Update version of package.json * Adding tests (#585) * Add new property `extensionsRgx` to config (#589) * Add new property `extensionsRgx` to config To be able to use custom Next.js page extensions (vercel/next.js#8454 (comment)), a new property `extensionsRgx` is added to the i18n configuration. # How to use // i18n.js ``` module.exports = { extensionsRgx: /\.(page|api)\.(tsx|ts|js|mjs|jsx)$/, ... } ``` * docs: add `extensionsRgx` configuration property * Update package.json * Listen for `namespaces` changes and load necessary namespaces (#592) * Update package.json version * Revert "Add useMemo to useTranslation" (#605) This reverts commit 8abc458. # Conflicts: # package.json * Remove console.warn because is already solved on Next.js 10.2.1-canary.4 (#609) Already fixed in [Next.js canary 10.2.1-canary.4](https://github.com/vercel/next.js/releases/tag/v10.2.1-canary.4) Co-authored-by: AndrewB <[email protected]> Co-authored-by: slevy85 <[email protected]> Co-authored-by: Justin <[email protected]> Co-authored-by: Bernd Artmüller <[email protected]> Co-authored-by: Rihards Ščeredins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #533 .
I also added the corresponding unit test.
I hope it will be ok for you,
Thank you