Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TokenWrapper: wrapped token icon should fallback to original token's icon and have dashed border #9

Open
sohkai opened this issue Dec 3, 2019 · 0 comments
Open

TokenWrapper: wrapped token icon should fallback to original token's icon and have dashed border #9

sohkai opened this issue Dec 3, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@sohkai
Copy link
Contributor

sohkai commented Dec 3, 2019

We should fallback to using the original token icon, and apply a dashed border (see design).

The "wrapped" token may not have an official token icon, so we should fallback to using the original token's icon.

Doing this will require:

  • A change in aragon-ui to add an icon prop to the TokenBadge, overriding the default icon
  • Applying an useImageExist() check with tokenIconUrl(wrappedToken.address), and if not available, using tokenIconUrl(outsideToken.address) as a fallback
  • Applying the dashed-border on the icon component passed into TokenBadge
@sohkai sohkai added the enhancement New feature or request label Dec 3, 2019
@sohkai sohkai changed the title App: wrapped token icon should fallback to original token's icon and have dashed border TokenWrapper: wrapped token icon should fallback to original token's icon and have dashed border Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sohkai