Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contracts: Support revert reasons #116

Open
facuspagnuolo opened this issue Mar 28, 2020 · 1 comment
Open

Contracts: Support revert reasons #116

facuspagnuolo opened this issue Mar 28, 2020 · 1 comment

Comments

@facuspagnuolo
Copy link
Contributor

After migrating to Ethers JS, failing transactions do not display the revert error message. We should find a way to fix that (cc @sohkai ethers-io/ethers.js#596)
@facuspagnuolo facuspagnuolo changed the title Shared: Support revert reasons Contracts: Support revert reasons Mar 28, 2020
@sohkai
Copy link
Contributor

sohkai commented Apr 7, 2020

Depending on how we're using it, I believe this should be supported (at least in eth_calls!).

See ethers-io/ethers.js#368 (comment), ethers-io/ethers.js#446 (comment).

If we're hoping to get it automatically from a failed transaction that was sent (does web3.js do that? I'm surprised!), this might be useful: https://gist.github.com/gluk64/fdea559472d957f1138ed93bcbc6f78a#file-reason-js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sohkai @facuspagnuolo